916420 - Mozpool requests should log their request details

Status: RESOLVED FIXED

(Testing Graveyard :: Mozpool, defect)

Description

[Justin Wood (:Callek)]

Attachment: [mozpool] log request details

In mozpool request logs there is no indication of what the request actually _was_ which makes diagnosing possible issues with requests harder.

This patch goes explicit rather than implicit of dictionary keys, I don't know for sure the exact nature of the dict that is returned, so I didn't want to print out extra implementation details if its not all-data. If you have a different approach here that is not simple to describe, I don't mind this one getting stolen from me in order to fix it 'right'.

(This is applied ontop of Bug 916416 and would context-conflict only in README.md)

Comment 1

[Jake Watkins [:dividehex]]

Comment on attachment 804842 [details] [diff] [review]
[mozpool] log request details

This would be nice info to see in the request log.  Just remove the '...with ' and capitalize 'Request'

Comment 2

[Justin Wood (:Callek)]

some months later, this lands

remote:   https://hg.mozilla.org/build/mozpool/rev/b960432e7e99
remote:   https://hg.mozilla.org/build/mozpool/rev/e2f6d7feb21d