Closed Bug 916433 Opened 9 years ago Closed 9 years ago

The task in the "tail.js" file of the Downloads API tests is not executed

Categories

(Toolkit :: Downloads API, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla27
Tracking Status
firefox26 --- fixed
firefox27 --- fixed

People

(Reporter: Paolo, Assigned: Paolo)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

The task in the "tail.js" file of the Downloads API tests is not executed,
because the tail file is imported after the main test loop:

http://mxr.mozilla.org/mozilla-central/source/testing/xpcshell/head.js#341

In order to work as expected, as part of the main test loop, the tail file
should be included directly at the end of the other tests.
Attached patch The patch (obsolete) — Splinter Review
Attachment #804859 - Flags: review?(felipc)
Attached patch Unlock requestsSplinter Review
In order for HTTP finalization to work, all the pending requests should finish.
Attachment #804859 - Attachment is obsolete: true
Attachment #804859 - Flags: review?(felipc)
Attachment #804865 - Flags: review?(felipc)
Any reason to not add a call to run_next_test() on tail.js?
(In reply to :Felipe Gomes from comment #3)
> Any reason to not add a call to run_next_test() on tail.js?

While this appears to works today, I'm not aware of any other tests that add new tasks after the main test loop has finished running, so this is likely to break in subtle ways if new state is introduced in the test runner.
And actually, we've already exited the loop in _do_main when we get there, so the finalization with run_next_test appeared to work just by chance.

You may want to repeat the test for the Places crash in bug 906134 again with this patch applied, it's possible that waiting for database finalization didn't actually work with the other approach.
Attachment #804865 - Flags: review?(felipc) → review+
https://hg.mozilla.org/mozilla-central/rev/d35c36b33f4e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Attachment #804865 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/6c862ae466a5

Gavin's comment in bug 913110 comment 23 contains a general summary about the reason for tracking Firefox 26.
Blocks: 1113736
You need to log in before you can comment on or make changes to this bug.