Closed Bug 916433 Opened 10 years ago Closed 10 years ago
The task in the "tail
.js" file of the Downloads API tests is not executed
The task in the "tail.js" file of the Downloads API tests is not executed, because the tail file is imported after the main test loop: http://mxr.mozilla.org/mozilla-central/source/testing/xpcshell/head.js#341 In order to work as expected, as part of the main test loop, the tail file should be included directly at the end of the other tests.
In order for HTTP finalization to work, all the pending requests should finish.
Any reason to not add a call to run_next_test() on tail.js?
(In reply to :Felipe Gomes from comment #3) > Any reason to not add a call to run_next_test() on tail.js? While this appears to works today, I'm not aware of any other tests that add new tasks after the main test loop has finished running, so this is likely to break in subtle ways if new state is introduced in the test runner.
And actually, we've already exited the loop in _do_main when we get there, so the finalization with run_next_test appeared to work just by chance. You may want to repeat the test for the Places crash in bug 906134 again with this patch applied, it's possible that waiting for database finalization didn't actually work with the other approach.
Attachment #804865 - Flags: review?(felipc) → review+
Unfortunately this conflicted with the backout of bug 913110, so a bunch of things including this, had to be backed out for now: remote: https://hg.mozilla.org/integration/fx-team/rev/5736f23d8a22 remote: https://hg.mozilla.org/integration/fx-team/rev/fd257eef04b2 remote: https://hg.mozilla.org/integration/fx-team/rev/00593fe07777 remote: https://hg.mozilla.org/integration/fx-team/rev/ea0b23759685 remote: https://hg.mozilla.org/integration/fx-team/rev/cbc7af0a20c4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Attachment #804865 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/6c862ae466a5 Gavin's comment in bug 913110 comment 23 contains a general summary about the reason for tracking Firefox 26.
You need to log in before you can comment on or make changes to this bug.