Closed Bug 916509 Opened 6 years ago Closed 3 months ago

LoginManagerStorage_mozStorage.init takes 260ms to import legacy signons on firstrun

Categories

(Toolkit :: Password Manager, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED WONTFIX

People

(Reporter: mfinkle, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: perf)

I noticed the 260ms during startup on firstrun, in the Eideticker nytimes-postload test.

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/passwordmgr/storage-mozStorage.js#214

Dolske thinks we might be able to remove the code.
Android seems to be forcing the initialization of the DBs by firing this notification:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#631

Wes - Do we do this for Sync? Why do we need to do it at all? Can't Sync just wait for the DB to be created and ignore passwords until it does? I guess that means no passwords will be pulled into the DB from the cloud though.
Sync sounds familiar, I'm vaguely remembering a related discussion about which code should be responsible for initializing the DB/schema. In theory the sync backend could do it itself, but then we're duplicating code and have to worry about them doing different things.

Bug 717490 is for killing the legacy import.
Just a note that Dolske has removed the legacy import, but we still get dinked by a forced crypto initialization. See https://bugzilla.mozilla.org/show_bug.cgi?id=717490#c17
Blocks: 959776

This storage backend will be removed soon now that Fennec is no longer supported.

Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.