916575 - changing mail address in Edit Details dialog of star contact popup doesn't remove filled star on saving/closing

Status: NEW

(Thunderbird :: Message Reader UI, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Thunderbird 24.0b3 candidate 1 and Daily 20130915030206 on Windows XP SP3 32 bit

Changing the mail address in the Edit Details dialog of a star contact popup doesn't remove the filled star on saving/closing.

Steps to reproduce:
1. Create a new contact: Display name "Contact 1", e-mail address "[e-mail]".
2. Create a new message with Contact 1 as recipient, save it as draft.
3. Go to the Drafts folder and select the message.
4. Click on the star next to "Contact 1" in the header of the mail, then on "Edit Details".
5. Change the e-mail address to "[e-mail]".
6. Save the change.

Actual result:
Star is still filled yellow.

Expected result:
Star isn't filled anymore.

The fix for this should also apply to background tabs and standalone message windows.

Comment 1

[Wayne Mery (:wsmwk)]

Danny, can you reproduce this?

Comment 2

[Danny Colin [:sdk]]

(In reply to Wayne Mery (:wsmwk) from comment #1)

Danny, can you reproduce this?

Yes. IMO, I wouldn't consider it a bug but a feature. For me changing the email address shouldn't remove the contact's star since it's still a known one.

Comment 3

[Wayne Mery (:wsmwk)]

(In reply to Danny Colin [:sdk] from comment #2)

For me changing the email address shouldn't remove the contact's star since it's still a known one.

Ah, but step 5 is to change the contact to an unknown address. It's probably failed like this since version 3.