Closed Bug 916683 Opened 6 years ago Closed 6 years ago

clean up code that isn't needed anymore

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: sunfish, Assigned: sunfish)

Details

(Keywords: dev-doc-complete)

Attachments

(3 files)

The following are a few patches which remove code which doesn't appear to be needed anymore.
Attachment #805173 - Flags: review?(n.nethercote)
Attachment #805174 - Flags: review?(n.nethercote)
Attachment #805176 - Flags: review?(n.nethercote)
Attachment #805174 - Flags: review?(n.nethercote) → review+
Comment on attachment 805176 [details] [diff] [review]
preprocessor-tidy.patch

Review of attachment 805176 [details] [diff] [review]:
-----------------------------------------------------------------

I strongly recommend a try server run (try: -b do -p all -u none -t none) before landing this.
Attachment #805176 - Flags: review?(n.nethercote) → review+
Attachment #805173 - Flags: review?(n.nethercote) → review+
(In reply to Nicholas Nethercote [:njn] from comment #3)
> Comment on attachment 805176 [details] [diff] [review]
> preprocessor-tidy.patch
> 
> Review of attachment 805176 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I strongly recommend a try server run (try: -b do -p all -u none -t none)
> before landing this.

https://tbpl.mozilla.org/?tree=Try&rev=a6aff694cee4

which had one odd failure, so I reran that one and it passed:

https://tbpl.mozilla.org/?tree=Try&rev=eb387b5c26c5
> which had one odd failure, so I reran that one and it passed:

If the build had failed, it would have been red.  Orange indicates test failure -- as well as doing a build, the "B" jobs run a few tests, and one of those failed.  We've been seeing intermittent failures quite a bit recently.

You can re-trigger an individual try job by clicking on the letter (e.g. the "B") and then clicking on the '+' in the box at the bottom left.  (But you might need a mozilla.com LDAP password to do that;  you could ask someone on IRC to do it for you.)
(In reply to Tom Schuster [:evilpie] from comment #7)
> Added annotation here
> https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/
> JSAPI_reference
> Mentioned on
> https://developer.mozilla.org/en-US/docs/SpiderMonkey/31#Obsolete_APIs

Thanks! I made a small correction, as JS_NewUCString is the drop-in replacement for JS_NewGrowableString:

https://developer.mozilla.org/en-US/docs/SpiderMonkey/31$compare?to=469239&from=468839
You need to log in before you can comment on or make changes to this bug.