profile.sh does not work if busybox exists on device

RESOLVED FIXED

Status

Firefox OS
GonkIntegration
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: swu, Assigned: swu)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Some scripts in profile.sh assumes output format was generated by toolbox, which caused failure if busybox exists in the system.

$ ./profile.sh ps
  PID Name
----- ----------------
    0 cat: can't open '/proc/0/comm': No such file or directory profiler not running
    0 cat: can't open '/proc/0/comm': No such file or directory profiler not running
    0 cat: can't open '/proc/0/comm': No such file or directory profiler not running
    0 cat: can't open '/proc/0/comm': No such file or directory profiler not running
    0 cat: can't open '/proc/0/comm': No such file or directory profiler not running
(Assignee)

Comment 1

5 years ago
Created attachment 805178 [details] [diff] [review]
Patch: Explicitly use toolbox commands
Assignee: nobody → swu
Status: NEW → ASSIGNED
Attachment #805178 - Flags: review?(dhylands)
Comment on attachment 805178 [details] [diff] [review]
Patch: Explicitly use toolbox commands

Review of attachment 805178 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #805178 - Flags: review?(dhylands) → review+
https://github.com/mozilla-b2g/B2G/commit/a8a44b5b5ce8c100882feb524913caf3da2b26c3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.