Closed
Bug 916684
Opened 11 years ago
Closed 11 years ago
profile.sh does not work if busybox exists on device
Categories
(Firefox OS Graveyard :: GonkIntegration, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: swu, Assigned: swu)
Details
Attachments
(1 file)
|
1.14 KB,
patch
|
dhylands
:
review+
|
Details | Diff | Splinter Review |
Some scripts in profile.sh assumes output format was generated by toolbox, which caused failure if busybox exists in the system.
$ ./profile.sh ps
PID Name
----- ----------------
0 cat: can't open '/proc/0/comm': No such file or directory profiler not running
0 cat: can't open '/proc/0/comm': No such file or directory profiler not running
0 cat: can't open '/proc/0/comm': No such file or directory profiler not running
0 cat: can't open '/proc/0/comm': No such file or directory profiler not running
0 cat: can't open '/proc/0/comm': No such file or directory profiler not running
|
Assignee | |
Comment 1•11 years ago
|
||
|
||
Comment 2•11 years ago
|
||
Comment on attachment 805178 [details] [diff] [review] Patch: Explicitly use toolbox commands Review of attachment 805178 [details] [diff] [review]: ----------------------------------------------------------------- Looks good.
Attachment #805178 -
Flags: review?(dhylands) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Pull request: https://github.com/mozilla-b2g/B2G/pull/277
|
|
||
Comment 4•11 years ago
|
||
https://github.com/mozilla-b2g/B2G/commit/a8a44b5b5ce8c100882feb524913caf3da2b26c3
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•