Closed Bug 916782 Opened 11 years ago Closed 11 years ago

Remove progress_activity.css and status.css from homescreen (it is only needed for ev.me)

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Homescreen
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:koi+, b2g-v1.2 fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g koi+
Tracking Flags:
Tracking Status
b2g-v1.2 --- fixed

People

(Reporter: crdlc, Assigned: crdlc)

References

Details

(Whiteboard: QARegressExclude)

Attachments

(1 file)

Patch v1
190 bytes, text/html
ranbena
: review+
Details 
We have to load this CSS file lazy with ev.me
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Summary: Remove progress_activity.css from homescreen (it is only needed for ev.me) → Remove progress_activity.css and status.css from homescreen (it is only needed for ev.me)
Blocks: 916827
Actually progress_activity.css is needed before Evme loads to show progress.
Attached file Patch v1 — 

        Attachment #805321 -
        Flags: review?(21)

    
  
blocking-b2g: --- → koi?

    
    

    
  
(In reply to Ran Ben Aharon (Everything.me) from comment #1)
> Actually progress_activity.css is needed before Evme loads to show progress.

Yeap, it is loaded the first 

https://github.com/mozilla-b2g/gaia/pull/12246/files#L0R108

    
    

    
  
Furthermore the SettignsListener object is loaded before Evme.Analytics because this is the unique place where is used. So the homescreen loads in less time

    
    

    
  
Comment on attachment 805321 [details]
Patch v1

Since this is e.me related I would prefer if ran can look at it.

        Attachment #805321 -
        Flags: review?(21) → review?(ran)

    
    

    
  
It makes sense ;)

        Attachment #805321 -
        Flags: review?(ran) → review+

    
    

    
  
Tests are ok.
But has unrelated fail on Travis :/ Can you rebase and push?

    
    

    
  
Homescreen tests are ok so merging into master

https://github.com/mozilla-b2g/gaia/commit/2e88444c39998e0b90513ad9f8ab9413f3fe246f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
blocking-b2g: koi? → koi+

    
    

    
  
Uplifted 2e88444c39998e0b90513ad9f8ab9413f3fe246f to:
v1.2: 46504717b9316b63242c15760fecf6eb7ca131f1

          status-b2g-v1.2:
          --- → fixed

    
  
Whiteboard: QARegressExclude

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: