Closed
Bug 916795
Opened 13 years ago
Closed 13 years ago
GenerationalGC: Error building browser with GGC enabled
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
|
841 bytes,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
I see the following error:
In file included from ../../dist/include/jsapi.h:22:0,
from ../../dist/include/GfxInfoCollector.h:11,
from ../../dist/include/gfxPlatform.h:23,
from ../../../layout/style/AnimationCommon.cpp:6:
../../dist/include/jspubtd.h: In constructor 'JS::shadow::Runtime::Runtime(js::gc::StoreBuffer*)':
../../dist/include/jspubtd.h:207:7: error: declaration of 'gcStoreBufferPtr' shadows a member of 'this' [-Werror=shadow]
cc1plus: all warnings being treated as errors
make[6]: *** [AnimationCommon.o] Error 1
make[5]: *** [style_compile] Error 2
|
Assignee | |
Updated•13 years ago
|
OS: Mac OS X → Linux
|
|
Assignee | |
Comment 1•13 years ago
|
||
GCC is complaining that argument gcStoreBufferPtr shadows the method of the same name.
Looks like fallout from bug 910771.
Attachment #805306 -
Flags: review?(n.nethercote)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 805306 [details] [diff] [review]
fix-build-error
Review of attachment 805306 [details] [diff] [review]:
-----------------------------------------------------------------
r=me. I was wondering why -Werror=shadow was set, because it's not on for general code. But then I remembered that bug 563195 turned it on just for layout/ code.
Attachment #805306 -
Flags: review?(n.nethercote) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•