916795 - GenerationalGC: Error building browser with GGC enabled

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jon Coppeard (:jonco)]

I see the following error:

In file included from ../../dist/include/jsapi.h:22:0,
                 from ../../dist/include/GfxInfoCollector.h:11,
                 from ../../dist/include/gfxPlatform.h:23,
                 from ../../../layout/style/AnimationCommon.cpp:6:
../../dist/include/jspubtd.h: In constructor 'JS::shadow::Runtime::Runtime(js::gc::StoreBuffer*)':
../../dist/include/jspubtd.h:207:7: error: declaration of 'gcStoreBufferPtr' shadows a member of 'this' [-Werror=shadow]
cc1plus: all warnings being treated as errors
make[6]: *** [AnimationCommon.o] Error 1
make[5]: *** [style_compile] Error 2

Comment 1

[Jon Coppeard (:jonco)]

Attachment: fix-build-error

GCC is complaining that argument gcStoreBufferPtr shadows the method of the same name.

Looks like fallout from bug 910771.

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 805306 [details] [diff] [review]
fix-build-error

Review of attachment 805306 [details] [diff] [review]:
-----------------------------------------------------------------

r=me.  I was wondering why -Werror=shadow was set, because it's not on for general code.  But then I remembered that bug 563195 turned it on just for layout/ code.

Comment 3

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/223905d27caa

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/223905d27caa