916815 - windows 7 talos runs appear to have a javascript error in mozillafilelogger, suspecting it is the cause of the timeout

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

Based on the logs:
https://tbpl.mozilla.org/php/getParsedLog.php?id=27894724&tree=Fx-Team#error1

It appears there is a javascript error:
21:16:07     INFO -  JavaScript error: chrome://pageloader/content/MozillaFileLogger.js, line 112: NS_BASE_STREAM_CLOSED: Component returned failure code: 0x80470002 (NS_BASE_STREAM_CLOSED) [nsIFileOutputStream.write]

This is most likely related to this other message I see in the logs:
21:17:02     INFO -  [Child 3792] WARNING: pipe error: 109: file e:/builds/moz2_slave/fx-team-w32-000000000000000000/build/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 312

I believe we can be smarter about accessing the write() call to the file stream.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add try/catch and retry to mfl.write() (1.0)

Comment 2

[Jeff Hammel]

Comment on attachment 805314 [details] [diff] [review]
add try/catch and retry to mfl.write() (1.0)

Review of attachment 805314 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!  Sorry for the lag.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

https://hg.mozilla.org/build/talos/rev/e11c30b59cef