Change UserProfile.__getattribute__ to not depend on privacy_fields

VERIFIED FIXED

Status

Participation Infrastructure
Phonebook
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: giorgos, Assigned: dpoirier)

Tracking

Details

(Whiteboard: [kb=1117257] )

(Reporter)

Description

4 years ago
Currently UserProfile.__getattribute__ checks privacy_fields dictionary to determine if a field is privacy protected and based on that to return the appropriate value.

This caused bug 916319, where a privacy field was added to the model but not in the dictionary, resulting in privacy choice not to be respected.

We should alter __getattribute__ to make decisions only based on the available fields and remove the privacy_fields duplication  altogether.
(Reporter)

Updated

4 years ago
OS: Linux → All
Hardware: x86_64 → All
Whiteboard: [kb=1117257]
(Assignee)

Updated

4 years ago
Assignee: nobody → dpoirier
Status: NEW → ASSIGNED

Comment 2

4 years ago
Commit pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/2c5adbab00634fddc09ec9b8c7e47e2c5335d41e
Bug 916819 -  Change UserProfile.__getattribute__ to not depend on privacy_fields
fixed in the above commit in Comment #2.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
I've tried a number of ways of twiddling privacy settings on stage(for every single field) and everything appears to be in order, I can't find any regressions with regard to privacy settings.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.