Closed
Bug 916920
Opened 12 years ago
Closed 12 years ago
getdimensions script/page has issues with json parsing
Categories
(Testing Graveyard :: Eideticker, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wlach, Assigned: wlach)
Details
Attachments
(2 files)
|
1.93 KB,
patch
|
davehunt
:
review+
|
Details | Diff | Splinter Review |
|
804 bytes,
patch
|
davehunt
:
review+
|
Details | Diff | Splinter Review |
Not sure how this ever worked. Because the capture server doesn't actually return well-formatted json responses, the javascript driving the getdimensions test page isn't working. Trivially fixable.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #805511 -
Flags: review?(dave.hunt)
|
|
Assignee | |
Comment 2•12 years ago
|
||
This is just some extra cleanup I did while I was there.
Attachment #805512 -
Flags: review?(dave.hunt)
|
||
Updated•12 years ago
|
Attachment #805511 -
Flags: review?(dave.hunt) → review+
|
|
||
Updated•12 years ago
|
Attachment #805512 -
Flags: review?(dave.hunt) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Pushed:
https://github.com/mozilla/eideticker/commit/967bbe9caf0fa93e7a2dbe3eaa471f30938ff5fa
https://github.com/mozilla/eideticker/commit/1d5d2cfb550f15fd29ce0a6a59d11fdd3f0bdc4a
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•