916930 - get rid of environment variable hacks from release repack script

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[[e-mail] (:bhearsum)]

These were added in bug 902091 to deal with pymake related fallout. They're dangerous because they assume a bunch of paths exist on the machine they run. According to a comment in the script:
+        # HACK!! We need to get rid of this script, ideally by 24.0b2.
+        # The core issue here is that env vars in mozconfigs are only there
+        # for configure, not make, so we fall back to MSVS8.

And we're way past 24.0b2.

Comment 1

[Aki Sasaki (not active)]

I believe these are removable without breaking anything, since we switched to w64 build slaves.  I'm a little hesitant to do so right before 25.0b1, but I'm not sure when a *good* time would be.

Comment 2

[[e-mail] (:bhearsum)]

(In reply to Aki Sasaki [:aki] from comment #1)
> I believe these are removable without breaking anything, since we switched
> to w64 build slaves.  I'm a little hesitant to do so right before 25.0b1,
> but I'm not sure when a *good* time would be.

It looks like 17.0esr is still on 32-machines based on the logs in https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/17.0.9esr-candidates/build1/logs/. We still have two more of those releases, too.

Comment 3

[Aki Sasaki (not active)]

I believe 17esr isn't forced to use pymake, either, so doesn't hit that block.

Comment 4

[[e-mail] (:bhearsum)]

(In reply to Aki Sasaki [:aki] from comment #3)
> I believe 17esr isn't forced to use pymake, either, so doesn't hit that
> block.

Duh, thanks. You're on releaseduty next week for b2 - can we try backing it out on Monday?

Comment 5

[Aki Sasaki (not active)]

Attachment: remove_hack

Sure.

I believe we still need the sign cmd hack, and the best fix here is to get mgerva's stuff live.  But this should be less hacky than before this patch.

Comment 6

[Aki Sasaki (not active)]

Comment on attachment 805509 [details] [diff] [review]
remove_hack

https://hg.mozilla.org/build/tools/rev/92eb1f309fae