916954 - Permanent UX Windows-only mochitest-bc orange: TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_876926_customize_mode_wrapping.js | application timed out after 330 seconds with no output | PROCESS-CRASH

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[:Gijs (he/him)]

09:10:35     INFO -  INFO TEST-END | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_876926_customize_mode_wrapping.js | finished in 6690ms
09:10:35     INFO -  TEST-INFO | checking window state
09:10:35     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_876926_customize_mode_wrapping.js | must wait for focus

Followed by a bunch of places failures, followed by a shitload of:
09:16:08     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_876926_customize_mode_wrapping.js | Console message: [JavaScript Error: "DEPRECATION WARNING: Field 'creationDate' is deprecated.

followed by a timeout crash (?)

09:21:40  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_876926_customize_mode_wrapping.js | application timed out after 330 seconds with no output

And everything goes sadfaces. I'll look at this more tomorrow, but if anyone knows what's wrong sooner than I do, then feel free. If anyone thinks it's urgent/necessary to back out what caused this, please back out bug 876926 only (not the followup I already landed that otherwise fixed the orange, which fixes other bugs, too).

Example log: https://tbpl.mozilla.org/php/getParsedLog.php?id=27930962&tree=UX

Comment 1

[Ed Morley [:emorley]]

Adding keyword so that TBPL can suggest this bug.

Comment 2

[Legacy TBPL/Treeherder Robot]

Gijs
https://tbpl.mozilla.org/php/getParsedLog.php?id=27955665&tree=UX
Windows 7 32-bit ux opt test mochitest-browser-chrome on 2013-09-17 01:39:17
revision: ac5cd088f385
slave: t-w732-ix-039

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_876926_customize_mode_wrapping.js | application timed out after 330 seconds with no output
PROCESS-CRASH | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_876926_customize_mode_wrapping.js | application crashed [@ CrashingThread(void *)]
Return code: 1

Comment 3

[Legacy TBPL/Treeherder Robot]

dao
https://tbpl.mozilla.org/php/getParsedLog.php?id=27955700&tree=UX
Windows XP 32-bit ux opt test mochitest-browser-chrome on 2013-09-17 01:38:51
revision: ac5cd088f385
slave: t-xp32-ix-011

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_876926_customize_mode_wrapping.js | application timed out after 330 seconds with no output
PROCESS-CRASH | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_876926_customize_mode_wrapping.js | application crashed [@ CrashingThread(void *)]
Return code: 1

Comment 4

[Legacy TBPL/Treeherder Robot]

dao
https://tbpl.mozilla.org/php/getParsedLog.php?id=27955715&tree=UX
WINNT 6.2 ux opt test mochitest-browser-chrome on 2013-09-17 01:39:47
revision: ac5cd088f385
slave: t-w864-ix-110

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_876926_customize_mode_wrapping.js | application timed out after 330 seconds with no output
PROCESS-CRASH | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_876926_customize_mode_wrapping.js | application crashed [@ CrashingThread(void *)]
Return code: 1

Comment 5

[:Gijs (he/him)]

Attachment: Fix windows focus-originated bc orange by closing the panel we open, rs=bustage

I just landed this, and verified locally that it fixes the timeout, which is apparently caused by our Windows focus code not dealing with opening a window, opening a panel in it, and then closing the parent window (and thereby the panel). So we end up with a nulled out activeWindow in the focus manager, which broke the test flow. I'll file a followup bug on our focus code regarding this if one doesn't already exist.

Comment 6

[Legacy TBPL/Treeherder Robot]

Gijs
https://tbpl.mozilla.org/php/getParsedLog.php?id=27956577&tree=UX
Windows XP 32-bit ux debug test mochitest-browser-chrome on 2013-09-17 01:52:11
revision: ac5cd088f385
slave: t-xp32-ix-085

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_876926_customize_mode_wrapping.js | application timed out after 330 seconds with no output
PROCESS-CRASH | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_876926_customize_mode_wrapping.js | application crashed [@ CrashingThread(void *)]
Return code: 1

Comment 7

[:Gijs (he/him)]

Filed bug 917294 for the underlying focus issue. This issue has gone away with the patch I landed, so closing this as FIXED.

Comment 8

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/21f5241b4c85