917009 - Assertion failure: aFirst && aSecond (Don't pass null pointers!), at caps/src/nsScriptSecurityManager.cpp:941

Status: RESOLVED FIXED

(Core :: Security: CAPS, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

While using https://twitter.com/ (I think I was trying to search for a user in the box at the top), I hit the fatal assertion:

Assertion failure: aFirst && aSecond (Don't pass null pointers!), at /home/dbaron/builds/ssd/mozilla-central/mozilla/caps/src/nsScriptSecurityManager.cpp:941


Might not be caps's fault, though, given the massive instability in builds today.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: end of browser output and a bit of gdb use

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Hit it a second time, just loading https://twitter.com/

Comment 3

[Bobby Holley (:bholley)]

So, this is happening because the old-fashioned mechanism for accessing object principals (which we invoke in debug builds to check our results) is returning null for some reason. I'm mildly curious to know why, but I think this code can also just go away. I'll attach a patch.

Comment 4

[Bobby Holley (:bholley)]

Attachment: Remove old-style object principal calculation. v1

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 806087 [details] [diff] [review]
Remove old-style object principal calculation. v1

r=me

Comment 6

[Bobby Holley (:bholley)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/68f90745d4b1

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/68f90745d4b1