917013 - Please add windows functions to getcert.cgi

Status: RESOLVED WORKSFORME

(Infrastructure & Operations :: RelOps: Puppet, task)

Description

[Q]

Per IRC conversations with Dustin. We need to be able to get a native windows executable version of certs.sh returned via getcert.cgi for our windows puppetize scripts. 

Options currently include simply returning a certs.bat file or possibly getting fancy and returning json objects. Backward compatibility should be incorporated so these functions should only be activated via new arguments. ( I.E. &windows=1&JSON=1 etc) with the current behavior being the default.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Compatibility isn't actually such a big deal - if we do this with JSON, then we can just adjust puppetize.sh in the same commit.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug917013.patch

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

As a reminder to myself, I'll need to update puppetize.sh on the DS servers.

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Q, ping?

Comment 5

[Q]

Sorry first time I've had a tag for review.  As a quick note this change will break the testing Mark is doing with puppett and my hacked script.

Comment 6

[Q]

Comment on attachment 806042 [details] [diff] [review]
bug917013.patch

looks nice and simple. json objects can be parsed client side. I don't see any obvious errors.

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 806042 [details] [diff] [review]
bug917013.patch

In the attachment details, set the "review" flag to + (or - if it's not ready to land).

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

If you need to land this while I'm away, feel free.  It should "just work" for kickstarts, and will need the puppetize.sh file copied to the DeployStudio servers in order to make OS X deploys work.

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

So, how/when shall we land this?

Comment 10

[Dustin J. Mitchell [:dustin] (he/him)]

As a note to self, this will need a followon fix to the masterize process, which runs deployment_getcert.sh directly.

Comment 11

[Dustin J. Mitchell [:dustin] (he/him)]

We're going to stick with the current status for the moment, until we have puppet running on Windows.  Then, we'll swap in the new, JSON-reading vbs script (which isn't written yet) using puppet itself.

Comment 12

[Dustin J. Mitchell [:dustin] (he/him)]

We really should land this at some point....

Comment 13

[Dustin J. Mitchell [:dustin] (he/him)]

we can shipz this nao?

Comment 14

[Dustin J. Mitchell [:dustin] (he/him)]

AIUI Q's working on this.  I'll be happ to do the landing when it's ready.

Comment 15

[Q]

json parsing vbs is still being worked on. stalled due to the fact that authentication seems to kill the json get.

Comment 16

[Q]

Dustin please go ahead and land the patches. We are past the point that it affects Mark's testing and I can tweak the vbs as needed after the getcert.cgi lands.

Comment 17

[Dustin J. Mitchell [:dustin] (he/him)]

Rail, will landing this make the spot-instance-creation stuff fail?

Comment 18

[Rail Aliiev [:rail]]

(In reply to Dustin J. Mitchell [:dustin] (I ignore NEEDINFO) from comment #17)
> Rail, will landing this make the spot-instance-creation stuff fail?

Yeah. We rely on the fact that the content returned by getcert.py is a shell script, which dumps certs to the files...

Comment 19

[Dustin J. Mitchell [:dustin] (he/him)]

How difficult would it be to rework that to accept JSON?  And how often does that happen -- do we need a downtime?

Comment 20

[Dustin J. Mitchell [:dustin] (he/him)]

Actually, let's put this on hold.  The way project X is looking, we may not be running puppet on windows (!).

Comment 21

[Dustin J. Mitchell [:dustin] (he/him)]

We probably *should* land this now, with no change to any clients.

Comment 22

[Dustin J. Mitchell [:dustin] (he/him)]

Q, is this moot now?