917026 - ASSERTION: TabChild::SetFocus not supported in TabChild: 'Not Reached' during several DOM mochitests on debug B2G

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jonathan Griffin (:jgriffin)]

When run on debug B2G emulators, the mochitest dom/tests/mochitest/bugs/test_bug664737.html fails with:

11:40:41     INFO -  7 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/bugs/test_bug664737.html | Assertion count 1 is greater than expected range 0-0 assertions.

The assertion that occurs is:

11:40:41     INFO -  2 INFO TEST-START | /tests/dom/tests/mochitest/bugs/test_bug664737.html
11:40:41     INFO -  [Child 705] ###!!! ASSERTION: TabChild::SetFocus not supported in TabChild: 'Not Reached', file ../../../gecko/dom/ipc/TabChild.cpp, line 937

full log: https://tbpl.mozilla.org/php/getParsedLog.php?id=27933969&tree=Cedar&full=1#error0

This is the only error that's affecting debug B2G mochitest chunk 5.

Comment 1

[Jonathan Griffin (:jgriffin)]

This also affects dom/tests/mochitest/dom-level1-core/test_hc_textsplittextone.html in chunk 6.

full log: https://tbpl.mozilla.org/php/getParsedLog.php?id=27933848&tree=Cedar&full=1#error0

Comment 2

[Jonathan Griffin (:jgriffin)]

Also 2 tests in chunk 8:

/tests/dom/tests/mochitest/dom-level2-html/test_HTMLSelectElement11.html | Assertion count 1 is greater than expected range 0-0 assertions.
/tests/dom/tests/mochitest/general/test_focus_legend_noparent.html | Assertion count 1 is greater than expected range 0-0 assertions.

full log: https://tbpl.mozilla.org/php/getParsedLog.php?id=27933653&tree=Cedar&full=1#error0

Comment 3

[Josh Matthews [:jdm]]

See also bug 676840.

Comment 4

[Andrew Overholt [:overholt]]

Is this something you could work on, dvander or felipe?  If not, any suggestions for a good owner?

Comment 5

[David Anderson [:dvander] - inactive, e-mail if emergency]

I can't see the logs anymore, do you have a newer one that has the stack trace?

This wouldn't be an IPC or TabChild bug though, it's something in the application embedding, or focus or widget code. Stack trace would help see which.

Comment 6

[Jonathan Griffin (:jgriffin)]

debug tests are temporarily completed busted due to bug 929139; when that's fixed, I'll link a new log.

Comment 7

[Andrew Overholt [:overholt]]

Olli, it's been said that you're knowledgeable in this area.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Attachment: warning

NS_NOTREACHED is very wrong.
Just calling any window.focus()/.blur() in child process leads to the
assertion because nsGlobalWindow::Focus()/Blur() calls them via
embedding APIs.
We may want to implement SetFocus/Blur for e10s, but NS_NOTREACHED is just
wrong, and let's fix the assertion.

Making also nsGlobalWindow::Blur to not throw exception.
That blur() really shouldn't throw, and we actually set focus in the focus manager anyway.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

https://tbpl.mozilla.org/?tree=Try&rev=2b384973d58b

Comment 10

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 821870 [details] [diff] [review]
warning

Review of attachment 821870 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe even the NS_WARNING is not necessary, as there's already the NS_ERROR_NOT_IMPLEMENTED..

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Well, that NS_ERROR_NOT_IMPLEMENTED isn't used at all...

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/572abeaaa0c0

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/572abeaaa0c0