917051 - SimplePush: Clean up unregister related code

Status: VERIFIED FIXED

(Core :: DOM: Push Subscriptions, defect)

Description

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Some dead code in there.

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: SimplePush: Clean up unregister related code.

Since we don't really care whether the server got the unregister, let's not handle the reply either.

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 805699 [details] [diff] [review]
SimplePush: Clean up unregister related code.

Review of attachment 805699 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/push/src/PushService.jsm
@@ +1134,5 @@
>            deferred.resolve(message);
>          },
>          function(error) {
>            // Unable to save.
> +          this._send("unregister", {channelID: record.channelID});

How did this work before?

Comment 3

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

(In reply to Doug Turner (:dougt) from comment #2)
> Comment on attachment 805699 [details] [diff] [review]
> SimplePush: Clean up unregister related code.
> 
> Review of attachment 805699 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/push/src/PushService.jsm
> @@ +1134,5 @@
> >            deferred.resolve(message);
> >          },
> >          function(error) {
> >            // Unable to save.
> > +          this._send("unregister", {channelID: record.channelID});
> 
> How did this work before?

_sendRequest() will keep track of the request with a timer and error with a timeout if it fails, and trickle that up to content JS, except we no longer have a watcher for it.

Comment 4

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/104e23b70187

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/104e23b70187

Comment 6

[Loli (:lolimartinezcr)]

tested and working
1.5 
Gecko fa7c5ad
Gaia 7c73c66