917056 - Make zoomed-svg-with-viewBox-01.svg use reftest-zoom

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Martijn Wargers (dead)]

Attachment: svg.diff

There is now the reftest-zoom attribute that can be used for reftests. Something that wasn't available, probably, at the time that test was written.

I wasn't able to test this patch yet (./mach reftest didnt't work for me, I got ImportError: cannot import name Preferences)

Comment 1

[Robert Longson [:longsonr]]

Please make the reftest run if you're going to fix it

http://mxr.mozilla.org/mozilla-central/source/layout/reftests/svg/moz-only/reftest.list#22

Comment 2

[Martijn Wargers (dead)]

Thanks! Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=00311cae54eb

Comment 3

[Martijn Wargers (dead)]

Ok, this reftest is failing, the reftest ellipse is much larger (3 times?) than the reference file.

Comment 4

[Martijn Wargers (dead)]

Attachment: 917056.diff (for check-in)

Ok, this seems to make it work.

Comment 5

[Martijn Wargers (dead)]

I pushed this to try: https://tbpl.mozilla.org/?tree=Try&rev=f9128379e6ef

Comment 6

[Martijn Wargers (dead)]

Try was green.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a08530866dee

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a08530866dee