Closed
Bug 917060
Opened 11 years ago
Closed 11 years ago
Column layout flicker
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
WORKSFORME
Tracking | Status | |
---|---|---|
firefox25 | --- | unaffected |
firefox26 | + | fixed |
firefox27 | + | unaffected |
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
References
()
Details
(Keywords: regression, reproducible, testcase)
Attachments
(2 files)
STR: 1. load the URL 2. wait 10-15 seconds ACTUAL RESULTS The main article text flicker every 5-10 seconds or so. It's in a -moz-column-count:2 layout according to Inspector. PLATFORMS AND BUILDS TESTED Bug occurs in Firefox Nightly 26.0a1 (2013-09-12) on Linux64 Bug does not occur in Firefox 23.0.1 on Linux64 Bug does not occur in my local beta (24) and aurora (25) debug builds. Bug does not occur in Chrome.
Assignee | ||
Updated•11 years ago
|
Version: Trunk → 26 Branch
Comment 1•11 years ago
|
||
Regression window(m-c) Good: http://hg.mozilla.org/mozilla-central/rev/3d20597e0a07 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130811002840 Bad: http://hg.mozilla.org/mozilla-central/rev/f057fca09627 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130812022940 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3d20597e0a07&tochange=f057fca09627 Regression window(m-i) Good: http://hg.mozilla.org/integration/mozilla-inbound/rev/9813b854b713 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130810082041 Bad: http://hg.mozilla.org/integration/mozilla-inbound/rev/072fffc8a0d1 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130810095641 Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=9813b854b713&tochange=072fffc8a0d1 Regressed by 072fffc8a0d1 Mats Palmgren — Bug 883568 - Call UpdateOverflow() in the scroll frame base class to actually update the overflow areas. r=roc
Blocks: 883568
tracking-firefox26:
--- → ?
Keywords: regressionwindow-wanted → regression
OS: Linux → All
Comment 2•11 years ago
|
||
How common is this layout? Can QA test out this bug on more frequently accessed sites to help find a testcase and to confirm user impact?
Keywords: qawanted
Updated•11 years ago
|
status-firefox25:
--- → unaffected
status-firefox26:
--- → affected
status-firefox27:
--- → affected
tracking-firefox27:
--- → +
Comment 3•11 years ago
|
||
I can easy reproduce this issue on Windows 7 x64 too using Latest Nightly 27. I think this is more related to JS because in the Error Console there is an JS error displayed while loading http://www.svd.se/kultur/kultursvepet-16-september_8522326.svd?sidan=2 Error: Permission denied to access property 'toString' this error is also related to Bug 783260 I would have said NPAPI could be also involved while handling certain content types but in this case there are no audio/mp3 or other content types used. Removing for now qawanted. Lukas if there is anything else I can investigate here please let me know.
Keywords: qawanted
Assignee: nobody → matspal
Assignee | ||
Comment 4•11 years ago
|
||
Re: comment 3. Can you still reproduce this in the latest Nightly? (it works for me on Linux64)
Flags: needinfo?(mihai.morar)
Comment 5•11 years ago
|
||
(In reply to Mats Palmgren (:mats) from comment #4) > Re: comment 3. Can you still reproduce this in the latest Nightly? > (it works for me on Linux64) I am not able to reproduce this issue using Latest Nightly 28 on Windows 7 x64 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 BuildID: 20131106030200 Marking as WFM based on my investigation done here and per Comment 4.
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(mihai.morar)
Resolution: --- → WORKSFORME
Assignee | ||
Comment 6•11 years ago
|
||
I can reproduce the problem with this testcase in Beta and Aurora, but not in Nightly on Linux64.
Assignee | ||
Comment 7•11 years ago
|
||
The problem was fixed on m-c in this interval: 2013-10-17-03-02-01 -- 2013-10-18-03-02-06 http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=423b9c30c73d&tochange=4e7d1e2c93a6
Assignee | ||
Comment 8•11 years ago
|
||
Bug 926706 is what fixed it. I've verified that applying the patch locally in a mozilla-beta build fixes it.
Depends on: 926706
Assignee | ||
Comment 9•11 years ago
|
||
I think column layout is still quite rare on the web in general, and the specific conditions that triggers this bug seems like it would be even more rare. That said, when it does occur it's quite disturbing, as the URL shows. So I think our best option for Aurora/Beta is to land bug 926706 and bug 928607 there. I think that would be straightforward and low-risk. Alternatively, not do anything and let the fixes ride the trains. Backing out bug 883568 seems like it would be riskier. That said, I think there is still an underlying bug in column reflow here in that reflowing it multiple times leads to different results. roc, what do you think about the risk of landing bug 926706 and bug 928607 on branches?
Flags: needinfo?(roc)
Assignee | ||
Comment 10•11 years ago
|
||
Actually, it's only Beta (26) that is affected, my Aurora build wasn't fully up-to-date when I tested it the first time. (bug 926706 and bug 928607 is already in 27)
Assignee | ||
Comment 11•11 years ago
|
||
(In reply to Mats Palmgren (:mats) from comment #9) > roc, what do you think about the risk of landing bug 926706 and bug 928607 > on branches? They're straightforward patches and there has been bake time. Let's try and get them on beta.
Flags: needinfo?(roc)
Comment 13•11 years ago
|
||
I've approved both uplifts in bug 926706 and bug 928607 - lets keep this bug tracking to confirm this works as expected.
Assignee | ||
Comment 14•11 years ago
|
||
I've landed those on Beta(26). It fixed the problem in my local mozilla-beta build. I filed bug 936652 to followup on the possible underlying bug in column layout.
Assignee | ||
Comment 15•11 years ago
|
||
We should try to make a reftest from the attached testcase.
Flags: in-testsuite?
You need to log in
before you can comment on or make changes to this bug.
Description
•