Closed Bug 917189 Opened 7 years ago Closed 7 years ago

There is a paused icon on the gutter after jumping to a source line from console

Categories

(DevTools :: Debugger, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 27

People

(Reporter: Optimizer, Assigned: b4bomsy)

Details

(Whiteboard: [good first bug][mentor=vporof@mozilla.com][lang=js])

Attachments

(1 file)

STR:
1) Be on any site with console errors/logs with a proper source link on the right
2) Click on the source link to be navigated to debugger with the corresponding line of the corresponding source as the current line

Expected result: 
The gutter should not have any paused icon (unless of course debugger is actually paused on the line)

Actual:
The line has a paused icon in the gutter to the left.
OS: Windows 7 → All
Priority: -- → P3
Hardware: x86_64 → All
Whiteboard: [good first bug][mentor=vporof@mozilla.com][lang=js]
Hi,
can i work on this.
Cheers
Hi! Thank you for contributing!

You'll need to edit the WC_viewSourceInDebugger function, in browser/devtools/webconsole/hudservice.js, which calls setEditorLocation with the required source url and line. There should be a param passed in that function that asks the debugger to not put a "debug" icon on the new caret position. See the setEditorLocation signature in browser/devtools/debugger-view.js for more details.

So

> DebuggerView.setEditorLocation(aSourceURL, aSourceLine);

becomes

> DebuggerView.setEditorLocation(aSourceURL, aSourceLine, { noDebug: true });

Do you have any experience with building Firefox from source?
Assignee: nobody → b4bomsy
Status: NEW → ASSIGNED
Yes,  I've fixed two patches prior to this.
Would a test be needed?
Attachment #812139 - Flags: feedback?(vporof)
Comment on attachment 812139 [details] [diff] [review]
Removed the debug icon that shows on the line

Review of attachment 812139 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is enough! Thank you.
Attachment #812139 - Flags: feedback?(vporof) → review+
Whiteboard: [good first bug][mentor=vporof@mozilla.com][lang=js] → [good first bug][mentor=vporof@mozilla.com][lang=js][land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/ecb3dbf54f5a
Whiteboard: [good first bug][mentor=vporof@mozilla.com][lang=js][land-in-fx-team] → [good first bug][mentor=vporof@mozilla.com][lang=js][land-in-fx-team][fixed-in-fx-team]
Whiteboard: [good first bug][mentor=vporof@mozilla.com][lang=js][land-in-fx-team][fixed-in-fx-team] → [good first bug][mentor=vporof@mozilla.com][lang=js][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/ecb3dbf54f5a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][mentor=vporof@mozilla.com][lang=js][fixed-in-fx-team] → [good first bug][mentor=vporof@mozilla.com][lang=js]
Target Milestone: --- → Firefox 27
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.