917198 - en-US: inconsistent use of "OK" and "KB" across Gaia apps and settings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Francesco Lodolo [:flod]]

I've just finished updating my localization for 1.2, and one thing that struck my eyes are those two simple words.

"OK": I think there's no space here for interpretation, it should be "OK", not "Ok". Matej, am I right?

\apps\communications\contacts\matcher\matcher.properties
ok = Ok

There was another one in 1.1 (facebook.properties), but apparently it's gone in 1.2.

KB. See also bug 814936 for one string, right now the situation is: 4 KB, 2 kB.

Can we get someone (who?) to make a final call and decide if we're writing kB (the correct one) or KB for en-US?

Comment 1

[Matej Novak [:matej]]

Great catch, flod.

The correct formatting should be "OK" and "KB"

Thanks.

Comment 2

[Francesco Lodolo [:flod]]

Pike, can we fix this without new IDs? I'd say yes being a matter of consistency for en-US.

Comment 3

[Axel Hecht [:Pike]]

Yeah.

Comment 4

[Francesco Lodolo [:flod]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12274/files

Pointer to Github pull-request

Comment 5

[Francesco Lodolo [:flod]]

Comment on attachment 806141 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12274/files

Trying :kaze for a review since it involves strings and multiple apps.

Comment 6

[Fabien Cazenave [:kaze]]

Comment on attachment 806141 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12274/files

Thanks! Merged on master: https://github.com/mozilla-b2g/gaia/commit/29aad9e4e63210105d3cac6d7e7a5748a7d68351

Comment 7

[Francesco Lodolo [:flod]]

Thanks kaze. 

We need this on 1.2 too, should I set a flag or do a different PR?

Comment 8

[Fabien Cazenave [:kaze]]

Let’s try these two flags: blocking-b2g:koi? and status-b2g-v1.2:affected.

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 29aad9e4e63210105d3cac6d7e7a5748a7d68351 to:
v1.2: 604b5eb5a1f381d236255892f9334b187bcc9a2a