Last Comment Bug 917203 - tracking flags with flag_type of "status" is unclear
: tracking flags with flag_type of "status" is unclear
Status: RESOLVED FIXED
:
Product: bugzilla.mozilla.org
Classification: Other
Component: Extensions: TrackingFlags (show other bugs)
: Production
: x86 Mac OS X
: -- normal (vote)
: ---
Assigned To: Byron Jones ‹:glob›
:
Mentors:
Depends on:
Blocks: 880829
  Show dependency treegraph
 
Reported: 2013-09-17 01:42 PDT by Byron Jones ‹:glob›
Modified: 2013-09-18 00:53 PDT (History)
3 users (show)
See Also:
Due Date:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
917203_1.patch (1.35 KB, patch)
2013-09-17 01:56 PDT, Byron Jones ‹:glob›
dkl: review+
Details | Diff | Splinter Review

Description Byron Jones ‹:glob› 2013-09-17 01:42:00 PDT
in TrackingFlags::Constants there's a flag_type of "status".  the migration code in bug 880829 doesn't migrate any existing fields into this flag_type.

it looks like it's only used in one place - the release tracking report only shows fields with this type.

however if a field's flag_type is changed from 'tracking' to 'status', it is displayed on show_bug in its own group, which isn't correct.


we should remove the 'status' flag_type, and change the report's code to do a regex on the flag's name.
Comment 1 Byron Jones ‹:glob› 2013-09-17 01:56:19 PDT
Created attachment 805872 [details] [diff] [review]
917203_1.patch
Comment 2 David Lawrence [:dkl] 2013-09-17 14:39:28 PDT
Comment on attachment 805872 [details] [diff] [review]
917203_1.patch

Review of attachment 805872 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Comment 3 Byron Jones ‹:glob› 2013-09-18 00:53:18 PDT
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
modified extensions/BMO/lib/Util.pm
modified extensions/TrackingFlags/lib/Constants.pm
Committed revision 9017.

Note You need to log in before you can comment on or make changes to this bug.