Create a System region for "cards view"

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: davehunt, Unassigned)

Tracking

unspecified

Firefox Tracking Flags

(firefox27 fixed, b2g18 affected, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix, b2g-v1.1hd wontfix, b2g-v1.2 affected)

Details

(Whiteboard: [gaia-ui-test])

Attachments

(1 attachment, 1 obsolete attachment)

Create a system region for "cards view" and migrate the cards view tests to use it.

This was originally filed as: https://github.com/mozilla/gaia-ui-tests/issues/1352
(Reporter)

Comment 1

5 years ago
Created attachment 805948 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12265

Pointer to Github pull-request
(Reporter)

Updated

5 years ago
Attachment #805948 - Flags: review?(bob.silverberg)
Just a note that this was originally submitted as https://github.com/mozilla/gaia-ui-tests/pull/1373. There were some comments added to that pull request.

Comment 3

5 years ago
Created attachment 806613 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12265

Pointer to Github pull-request
(Reporter)

Comment 4

5 years ago
Comment on attachment 806613 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12265

I'm guessing adding this patch again was a mistake.
Attachment #806613 - Attachment is obsolete: true
Attachment #805948 - Flags: review?(bob.silverberg) → review+
Landed in https://github.com/mozilla-b2g/gaia/commit/432a79aedb558d998ea88c04d43427a2082a67ee
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

5 years ago
Should we land this in 1.2? I think we should use the status-b2g-v1.2 flag to indicate bugs that should be uplifted.

Comment 7

5 years ago
Yes please uplift. to which setting should we set the flag?
(Reporter)

Comment 8

5 years ago
I've set the flags according to what I think they need to be to land this in master, v1.2 and v1-train. Perhaps we don't need this for v1-train though?

status-firefox27 - fixed (master)
status-b2g-v1.2 - affected (v1.2)
status-b2g18 - affected (v1-train)

Jason, can you confirm this is correct?
status-b2g18: --- → affected
status-b2g-v1.2: --- → affected
status-firefox27: --- → fixed
Flags: needinfo?(jsmith)
(In reply to Dave Hunt (:davehunt) from comment #8)
> I've set the flags according to what I think they need to be to land this in
> master, v1.2 and v1-train. Perhaps we don't need this for v1-train though?
> 
> status-firefox27 - fixed (master)
> status-b2g-v1.2 - affected (v1.2)
> status-b2g18 - affected (v1-train)
> 
> Jason, can you confirm this is correct?

That looks right. Although I'm wondering if not having leo+ even though this is test only will allow it to get uplifted by a tree manager. We might to followup with release management & tree management on the side to discuss this.
status-b2g18-v1.0.0: --- → wontfix
status-b2g18-v1.0.1: --- → wontfix
status-b2g-v1.1hd: --- → wontfix
Flags: needinfo?(jsmith)
You need to log in before you can comment on or make changes to this bug.