917222 - [Dailer] Unable to hang up the call after a specific sequence of actions on dialer during the call.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Enpei]

Attachment: logcat

Unable to hang up the call after pressing home key and back to dialer twice and press dial key on dialer again during the call. Please check reproduce steps and attached video which will make it more clear. Need to reboot to recover the issue.

Helix v1.1 has no such issue.

* Build Number                
Gaia:     c6b4cc05b2de6884a652c1c5ab8401216ffa46c1
Gecko:    78b3dbc50a8cddea792b6c2870c0bfbe3726335c
BuildID   20130917062051
Version   26.0a1

* Reproduce Steps
1. Dial out a number(no need to be emergency call as filmed in the video)and connected.
2. After connected, press home key > dialer > home key > dialer, you will see dialer page become not-in-call status with dial green key on the bottom.
3. Press the dial key.
Original call cannot be ended anymore no matter select in-call notification bar on top except reboot device.

* Expected Result
1. no matter how many times pressing buttons between home and dialer keys, in-call page will always show when press dialer key.
2. Call should be able to be ended.

* Actual Result
Original call cannot be ended anymore no matter select in-call notification bar on top except reboot device.

* Occurrence rate
100%

Comment 1

[Enpei]

Attachment: video

Comment 2

[Enpei]

Buri v1.2 has the same issue. So this is not wasabi specific one, update the summary.

Gaia:     7b6147372cbf560744a02be50e0a862a825caef6
Gecko:    http://hg.mozilla.org/releases/mozilla-aurora/rev/63a505ec015c
BuildID   20130922004001
Version   26.0a2

Comment 3

[Anthony Ricaud (:rik)]

From the last video frame on the call screen, it looks like we're calling the same number twice. I don't know yet if it's a Gaia or Gecko issue.

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

My observation:

If I repeated "home key" --> "green bar", call screen displayed as expected. The call number and the timer are shown correctly, and I could press the red button to hang up the call.

But if I repeated "home key" --> "dialer app" then the error happens (will attach a screen shot in the next commit). Note that you can still be back to a right call screen by tapping the green bar, and everything is fine, i.e. you can still hang up the call , even error happens in tapping the dialer app. It looks like a gaia issue.

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: screenshot for comment 4

screenshot for comment 4

Comment 6

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Anthony Ricaud (:rik) from comment #3)
> From the last video frame on the call screen, it looks like we're calling
> the same number twice. I don't know yet if it's a Gaia or Gecko issue.

According to the video, I saw the tester pressed the calling button twice. I believe that's why the last video frame shows two numbers there.

Comment 7

[Anthony Ricaud (:rik)]

We have two very separate issues here. I cannot reproduce the "Unable to hang up the call" part on an Unagi. So I tend to think this is a RIL issue.

For the green status bar issue, it might be a regression because of the conference call work.

QA: Can you find if these steps are a regression or have always been there:
1) Place a call
2) Press home button
3) Tap the dialer app icon
4) Press home button
5) Tap the dialer app icon

Expected:
I'm on the "incall" screen

Actual:
I'm on the dialer screen with a green status bar


PS: The bad rendering of the status bar is known and tracked in bug 918534.

Comment 8

[Darren]

The window appears to be between build 09/04 and 09/05. On build 09/04 the taping on the dialer app will open up the in-call screen, but on 09/05 the keypad gets brought up on the second or third press of the dialer app.

Something I noticed was between the two builds the icon for Adding an additional caller to the line was introduced so that might play a role in the issue.

Does not occurs in-
Buri Build ID: 20130904040205
Gecko: http://hg.mozilla.org/mozilla-central/rev/7ff96bd19c1c
Gaia: b6c5bf1d24230bfed4a8f680e625fa2175001f82
Platform Version: 26.0a1

Occurs in-
Buri Build ID: 20130905185329
Gecko: http://hg.mozilla.org/mozilla-central/rev/df8f342e9a6b
Gaia: b77dc7d399c14ac2bafe5c89566b292bc6772d32
Platform Version: 26.0a1

Repro Steps:
1. Open the Dialer
2. Dial a number and press the call button
3. Answer the call on the second device
4. Press the Home button
5. Tap on the Dialer app
6. Press the Home button
7. Tap on the Dialer app
8. Dial the same number and press the call button
9. Tap on the call at the top of the screen.
10. Press the end button

Comment 9

[Joe Cheng [:jcheng] (please needinfo)]

triage: koi+ for regression and hang up a call is important

Comment 10

[Anthony Ricaud (:rik)]

To me, the "unable to hangup" part is a manifestation of bug 916902.

Comment 11

[Etienne Segonzac (:etienne)]

A bunch of issues have been fixed since this bug was open:
* the weird grey bar
* the keypad phone number not being cleared early enough
* the add call button not going to the contact tab

Can we qa this again and see if we still have a blocking issue?

Comment 12

[Enpei]

Tested on Buri
Gaia:     79abf09f2b5b6440f43cb5ae44ef6c85c0437e8d
Gecko:    http://hg.mozilla.org/releases/mozilla-aurora/rev/c8e97fd5b94d
BuildID   20131011004001
Version   26.0a2

Step 2 issue can still be found, but call can be ended on step 3.

Yet I can still create call cannot be ended case if choose to dial another call in step 3, please check attached logcat, time stamp: 20:10, 10/11.

Comment 13

[Enpei]

Attachment: 20:10, 10/11.

Comment 14

[Etienne Segonzac (:etienne)]

Looks like we're getting a NS_ERROR_NOT_AVAILABLE when calling telephony.dial.
And looks like there are some RIL error also... any ideas?

10-11 20:09:46.919 E/GeckoConsole(  513): [JavaScript Error: "NS_ERROR_NOT_AVAILABLE: " {file: "app://communications.gaiamobile.org/dialer/js/telephony_helper.js" line: 54}]

Comment 15

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Etienne Segonzac (:etienne) from comment #14)
> Looks like we're getting a NS_ERROR_NOT_AVAILABLE when calling
> telephony.dial.
> And looks like there are some RIL error also... any ideas?
> 
> 10-11 20:09:46.919 E/GeckoConsole(  513): [JavaScript Error:
> "NS_ERROR_NOT_AVAILABLE: " {file:
> "app://communications.gaiamobile.org/dialer/js/telephony_helper.js" line:
> 54}]

Telephony.cpp allows making a dialing call in certain situation. [1]
In this error case, seems user tries to make a second outgoing call when there's another call with 'dialing,' 'alerting' or 'connecting.'

[1] http://mxr.mozilla.org/mozilla-central/source/dom/telephony/Telephony.cpp#214

Comment 16

[Etienne Segonzac (:etienne)]

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #15)
> (In reply to Etienne Segonzac (:etienne) from comment #14)
> > Looks like we're getting a NS_ERROR_NOT_AVAILABLE when calling
> > telephony.dial.
> > And looks like there are some RIL error also... any ideas?
> > 
> > 10-11 20:09:46.919 E/GeckoConsole(  513): [JavaScript Error:
> > "NS_ERROR_NOT_AVAILABLE: " {file:
> > "app://communications.gaiamobile.org/dialer/js/telephony_helper.js" line:
> > 54}]
> 
> Telephony.cpp allows making a dialing call in certain situation. [1]
> In this error case, seems user tries to make a second outgoing call when
> there's another call with 'dialing,' 'alerting' or 'connecting.'
> 

Should we prevent this form happening on the gaia side?
(if so, how ? :))

Comment 17

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Etienne Segonzac (:etienne) from comment #16)
> (In reply to Hsin-Yi Tsai  [:hsinyi] from comment #15)
> > (In reply to Etienne Segonzac (:etienne) from comment #14)
> > > Looks like we're getting a NS_ERROR_NOT_AVAILABLE when calling
> > > telephony.dial.
> > > And looks like there are some RIL error also... any ideas?
> > > 
> > > 10-11 20:09:46.919 E/GeckoConsole(  513): [JavaScript Error:
> > > "NS_ERROR_NOT_AVAILABLE: " {file:
> > > "app://communications.gaiamobile.org/dialer/js/telephony_helper.js" line:
> > > 54}]
> > 
> > Telephony.cpp allows making a dialing call in certain situation. [1]
> > In this error case, seems user tries to make a second outgoing call when
> > there's another call with 'dialing,' 'alerting' or 'connecting.'
> > 
> 
> Should we prevent this form happening on the gaia side?

It would be great.

> (if so, how ? :))

Could gaia simply check if there's another call with state 'dialing' 'alerting' or 'connecting' existing?

Comment 18

[Etienne Segonzac (:etienne)]

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #17)
> (In reply to Etienne Segonzac (:etienne) from comment #16)
> > (In reply to Hsin-Yi Tsai  [:hsinyi] from comment #15)
> > > (In reply to Etienne Segonzac (:etienne) from comment #14)
> > > > Looks like we're getting a NS_ERROR_NOT_AVAILABLE when calling
> > > > telephony.dial.
> > > > And looks like there are some RIL error also... any ideas?
> > > > 
> > > > 10-11 20:09:46.919 E/GeckoConsole(  513): [JavaScript Error:
> > > > "NS_ERROR_NOT_AVAILABLE: " {file:
> > > > "app://communications.gaiamobile.org/dialer/js/telephony_helper.js" line:
> > > > 54}]
> > > 
> > > Telephony.cpp allows making a dialing call in certain situation. [1]
> > > In this error case, seems user tries to make a second outgoing call when
> > > there's another call with 'dialing,' 'alerting' or 'connecting.'
> > > 
> > 
> > Should we prevent this form happening on the gaia side?
> 
> It would be great.
> 
> > (if so, how ? :))
> 
> Could gaia simply check if there's another call with state 'dialing'
> 'alerting' or 'connecting' existing?

Well it means inspecting all the call each time we place a call.
How costly do you think it would be? (the first time the user press the call button mozTelephony isn't even loaded yet)

Comment 19

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Etienne Segonzac (:etienne) from comment #18)
> (In reply to Hsin-Yi Tsai  [:hsinyi] from comment #17)
> > (In reply to Etienne Segonzac (:etienne) from comment #16)
> > > (In reply to Hsin-Yi Tsai  [:hsinyi] from comment #15)
> > > > (In reply to Etienne Segonzac (:etienne) from comment #14)
> > > > > Looks like we're getting a NS_ERROR_NOT_AVAILABLE when calling
> > > > > telephony.dial.
> > > > > And looks like there are some RIL error also... any ideas?
> > > > > 
> > > > > 10-11 20:09:46.919 E/GeckoConsole(  513): [JavaScript Error:
> > > > > "NS_ERROR_NOT_AVAILABLE: " {file:
> > > > > "app://communications.gaiamobile.org/dialer/js/telephony_helper.js" line:
> > > > > 54}]
> > > > 
> > > > Telephony.cpp allows making a dialing call in certain situation. [1]
> > > > In this error case, seems user tries to make a second outgoing call when
> > > > there's another call with 'dialing,' 'alerting' or 'connecting.'
> > > > 
> > > 
> > > Should we prevent this form happening on the gaia side?
> > 
> > It would be great.
> > 
> > > (if so, how ? :))
> > 
> > Could gaia simply check if there's another call with state 'dialing'
> > 'alerting' or 'connecting' existing?
> 
> Well it means inspecting all the call each time we place a call.
> How costly do you think it would be? (the first time the user press the call
> button mozTelephony isn't even loaded yet)

If it helps gaia, then I think it's also okay to expose another function to Telephony for checking if making a call is allowed. What we could do will be simply the same as [1]. But it still don't resolve your problem - the first time the user press the call button mozTelephony isn't even loaded yet. Here gaia work is required, I guess.

[1] http://mxr.mozilla.org/mozilla-central/source/dom/telephony/Telephony.cpp#214

Comment 20

[Etienne Segonzac (:etienne)]

After discussing with Joe, the blocking part here is the fact that the user cannot hang up.

Taking.

Comment 21

[Etienne Segonzac (:etienne)]

Attachment: Pointer to Gaia PR

Comment 22

[Natalya Kot [:nkot]]

(In reply to Etienne Segonzac (:etienne) from comment #20)

What was 'qawanted' for here? 

The issue still reproduces... 

Buri aurora
BuildID: 20131025004000
Gaia: 606517ceafe0950c2b89822d5f13353743334f2c
Gecko: 5eabd267ef04
Version: 26.0a2
Firmware: US_20131015

Comment 23

[Etienne Segonzac (:etienne)]

(In reply to nkot from comment #22)
> (In reply to Etienne Segonzac (:etienne) from comment #20)
> 
> What was 'qawanted' for here? 
> 
> The issue still reproduces... 

my mistake, sorry.

Comment 24

[Anthony Ricaud (:rik)]

Comment on attachment 822234 [details] [review]
Pointer to Gaia PR

Small nit in the PR.

Comment 25

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/d3173ac843208ce14cd74aba5c0420c50b81b4a1

Comment 26

[Enpei]

Hi Etienne, not sure if I can do this, I set tracking flag for v1.2 since it's not committed to v1.2 yet. Please correct me if the process is not like this, thanks.

Buri v1.2 still has the bug.
Gaia:     df049e3177ced0ca493ff0d192c65f18392bb462
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/93eafd042c1c
BuildID   20131031004003
Version   26.0

Comment 27

[Etienne Segonzac (:etienne)]

(In reply to Enpei from comment #26)
> Hi Etienne, not sure if I can do this, I set tracking flag for v1.2 since
> it's not committed to v1.2 yet. Please correct me if the process is not like
> this, thanks.

Not and expert but I think that's how we should do it yes :)

Comment 28

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted d3173ac843208ce14cd74aba5c0420c50b81b4a1 to:
v1.2: ee4cb6e1530cd52fb05741771a1c8fdd393d48e8

Comment 29

[Enpei]

verified master build 
Gaia:     412fd463bcb81f0e8bebf6d32500d0c02712748d                             
Gecko:    http://hg.mozilla.org/mozilla-central/rev/f0d363d72753             
BuildID   20131031040201                                                       
Version   28.0a1 

Also create another bug for step 2
"2. After connected, press home key > dialer > home key > dialer, you will see dialer page become not-in-call status with dial green key on the bottom."

Comment 30

[Enpei]

Verified on v1.2 branch

Gaia:     be4ea00a50236b10eb0a03232a28ffd0048e0cb8
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/3ba912717904
BuildID   20131105004003
Version   26.0