917246 - Make the tree compile again with --enable-pulse

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug XXXXXX - Make the tree compile with --enable-pulse.

Comment 2

[Paul Adenot (:padenot)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/58dbd84ae828

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

FYI, I r+'d the actual patch that landed (change to PA_* constant instead)

Comment 4

[Ed Morley [:emorley]]

The push this bug was in + followups have been backed out for crashes of form:
https://tbpl.mozilla.org/php/getParsedLog.php?id=27977619&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=27976043&tree=Mozilla-Inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/58dbd84ae828
https://hg.mozilla.org/integration/mozilla-inbound/rev/9524b1df278e
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb89f2090779
https://hg.mozilla.org/integration/mozilla-inbound/rev/fe576415129e
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e5d5e42f6c2
https://hg.mozilla.org/integration/mozilla-inbound/rev/b221626331b4
https://hg.mozilla.org/integration/mozilla-inbound/rev/2aa38a1a2b06
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d2aac8dc618
https://hg.mozilla.org/integration/mozilla-inbound/rev/ade49a801461
https://hg.mozilla.org/integration/mozilla-inbound/rev/4323508b3412

Comment 5

[Paul Adenot (:padenot)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/58508ae5e858

Comment 6

[Landry Breuil (:gaston)]

(In reply to Paul Adenot (:padenot) from comment #5)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/58508ae5e858

Thanks for that, i was puzzled by that new failure:
media/libcubeb/src/cubeb_pulse.c:587:49: error: 'PR_NSEC_PER_SEC' undeclared

using PR_* without including prtime.h .. tss tss

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/58508ae5e858