Closed Bug 917269 Opened 11 years ago Closed 11 years ago

Remove kFontAppleMyungjo

Categories

(Core :: Graphics, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

Details

Attachments

(1 file)

Attached patch Patch (v1)Splinter Review
This variable is unused.
Attachment #805952 - Flags: review?(jfkthame)
Comment on attachment 805952 [details] [diff] [review]
Patch (v1)

Review of attachment 805952 [details] [diff] [review]:
-----------------------------------------------------------------

Hmm. John, this comes from bug 705594. Did you intend to actually use this name?
Attachment #805952 - Flags: review?(jfkthame) → review?(jdaggett)
(In reply to Jonathan Kew (:jfkthame) from comment #1)
> Comment on attachment 805952 [details] [diff] [review]
> Patch (v1)
> 
> Review of attachment 805952 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Hmm. John, this comes from bug 705594. Did you intend to actually use this
> name?

If yes, it would be nice to add it back in the patch which adds the usage?  This currently breaks builds with warnings as errors on newer clang versions.
Note that this is now the only bug that breaks trunk builds with newer clang versions. :(
Comment on attachment 805952 [details] [diff] [review]
Patch (v1)

At this point, I can't say I remember... :P
Attachment #805952 - Flags: review?(jdaggett) → review+
https://hg.mozilla.org/mozilla-central/rev/76b02f97bebc
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: