Update gaia-ui-tests to address changes to lockscreen

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bsilverberg, Assigned: bsilverberg)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
A new lockscreen has been implemented which is causing the gaia-ui-tests for lockscreen to fail. The tests and/or lockscreen object need to be updated.
(Assignee)

Updated

5 years ago
Assignee: nobody → bob.silverberg
(Assignee)

Comment 1

5 years ago
Created attachment 806056 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12272

Pointer to Github pull-request
(Assignee)

Comment 2

5 years ago
Created attachment 806057 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12272#attch-to-bugzilla

Pointer to Github pull-request
(Assignee)

Updated

5 years ago
Attachment #806057 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #806056 - Flags: review?(zcampbell)
(Assignee)

Updated

5 years ago
Attachment #806056 - Flags: review?(florin.strugariu)
Attachment #806056 - Flags: review?(dave.hunt)
Do the changes to the lockscreen also mean bug 891882 is fixed? If so, we should get these tests running on desktop so we can see the results in Travis-CI.
Comment on attachment 806056 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12272

I'm currently unable to test this on desktop due to bug 917310, but the tests pass on my inari.
Attachment #806056 - Flags: review?(zcampbell)
Attachment #806056 - Flags: review?(florin.strugariu)
Attachment #806056 - Flags: review?(dave.hunt)
Attachment #806056 - Flags: review-
(Assignee)

Updated

5 years ago
Attachment #806056 - Flags: review- → review?(dave.hunt)
Comment on attachment 806056 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12272

Landed in:
https://github.com/mozilla-b2g/gaia/commit/5ff9232461a9d562e0a608c4b17b08efc723145f
https://github.com/mozilla-b2g/gaia/commit/849e6ae705e2a7a435abd679659ac736d4046a0a

Please squash into a single commit in future, and be sure to update the review requests and bug status.
Attachment #806056 - Flags: review?(dave.hunt) → review+
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.