Closed Bug 917360 Opened 6 years ago Closed 6 years ago

Aurora26 jit-test failures post-merge

Categories

(Core :: JavaScript Engine, defect, blocker)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla27
Tracking Flags:
Tracking Status
firefox26 + fixed
firefox27 --- fixed

People

(Reporter: RyanVM, Assigned: nmatsakis)

Details

(Whiteboard: [qa-])

Attachments

(2 files, 1 obsolete file)

Bug917360.diff
10.03 KB, patch
nbp
: review+
Details | Diff | Splinter Review
Bug917360-1.diff
1.35 KB, patch
Details | Diff | Splinter Review 
I'm guessing there's some missing NIGHTLY_BUILD ifdefs or something to that affect, given the failures shown in the log.

https://tbpl.mozilla.org/php/getParsedLog.php?id=27975781&tree=Mozilla-Aurora
I'm busy this afternoon in meetings, so a=akeybl on whatever needs to land to right this :)
Assignee: general → nicolas.b.pierron
tracking-firefox26: --- → +
Assignee: nicolas.b.pierron → nmatsakis
Attached patch Bug917360.diff (obsolete) — — Splinter Review 
From nbp
Attachment #806104 - Flags: review+
Attached patch Bug917360.diff — — Splinter Review
Attachment #806104 - Attachment is obsolete: true
Comment on attachment 806108 [details] [diff] [review]
Bug917360.diff

Review of attachment 806108 [details] [diff] [review]:
-----------------------------------------------------------------

19:35:21 <nmatsakis> nbp: there were two copies of the tests
19:35:24 <nmatsakis> nbp: failed renaming

Sounds good.
Attachment #806108 - Flags: review+
Attached patch Bug917360-1.diff — — Splinter Review 
Looking green, thanks! Please make sure these patches land on inbound too so we don't repeat this exercise 6 weeks from now.
I went ahead and folded the two patches together and pushed them to inbound. Thanks again!
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc710f6a68f5
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/fc710f6a68f5
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.