Closed Bug 917385 Opened 6 years ago Closed 6 years ago

Move precise/imprecise input tracking down to widget

Categories

(Core Graveyard :: Widget: WinRT, defect)

26 Branch
x86_64
Windows 8.1
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla27

People

(Reporter: jimm, Assigned: jimm)

References

Details

Attachments

(3 files)

It would be much simpler / more reliable to do this down in widget before we send events to the apz. We could fire observers when the state changes.
Blocks: 922908
Component: Widget: Win32 → Widget: WinRT
Duplicate of this bug: 922908
Attached patch patch v.1Splinter Review
tim for widget changes
Attachment #817296 - Flags: review?(tabraldes)
Comment on attachment 817296 [details] [diff] [review]
patch v.1

matt for input.js changes
Attachment #817296 - Flags: review?(mbrubeck)
Attachment #817296 - Flags: review?(mbrubeck) → review+
Attachment #817296 - Flags: review?(tabraldes)
Attached patch patch v1.1Splinter Review
I moved all that switch logic into a helper for the gesture events.
Attachment #817321 - Flags: review?(tabraldes)
Comment on attachment 817321 [details] [diff] [review]
patch v1.1

Review of attachment 817321 [details] [diff] [review]:
-----------------------------------------------------------------

Seems good to me.

::: widget/windows/winrt/MetroInput.h
@@ +155,5 @@
>  
>    ModifierKeyState mModifierKeyState;
>  
> +  // Tracking input type
> +  enum InputType {

nit: I would call this something like InputPrecisionLevel, just to be more precise ;)
Attachment #817321 - Flags: review?(tabraldes) → review+
Attached patch tests updateSplinter Review
follow up patch that updates some failing tests. I would like to have kept the event sending, but our event utils touch event senders don't call simulate event widget helpers, so I can't pick these up easily down in the tracking code.
Attachment #817877 - Flags: review?(mbrubeck)
Attachment #817877 - Flags: review?(mbrubeck) → review+
https://hg.mozilla.org/mozilla-central/rev/96905a5e44e6
https://hg.mozilla.org/mozilla-central/rev/ef27681c50f7
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Depends on: 928157
Depends on: 934597
OS: Windows 8 Metro → Windows 8.1
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.