917387 - [B2G][Bluetooth][File transfer] Picture in preview shows zoomed in when user opens picture received via Bluetooth.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Nick Davidson]

Attachment: Zoomed-in preview vs actual pic.JPG

Description:
When user taps on notification that Bluetooth transfer is complete, picture preview opens up, but user is only able to see zoomed-in upper left corner of the picture

Repro Steps:
1) Updated Buri to Build ID: 20130916040205
2) Pair 2 devises via Bluetooth
3) Send pic from device A to device B via bluetooth
4) On device B Tap on notification "File received"
5) Observe what is on a screen when picture preview opens up

Actual:
Picture previue only shows about 1/6 of actual pic on a screen.(it zoomed in to upper left corner of the pic)

Expected:
User is able to see whole picture during preview

Environmental Variables
Build ID: 20130916040205
Gecko: http://hg.mozilla.org/mozilla-central/rev/c4bcef90cef9
Gaia: a0079597d510ce8ea0b9cbb02c506030510b9eeb
Platform Version: 26.0a1

Notes:
Repro frequency: 100%
See attached: screenshot, logcat, 
Optional workarounds - user can see picture normally, if he goes to gallery
Optional extra notes: While zoomed-in in preview mode user is unable to zoom out picture using pinch-in gesture or move zoomed area of the pic around the screen.

Comment 1

[Nick Davidson]

Attachment: Recived-PIC-Via-Bluetooth.txt

Comment 2

[Eric Chou [:ericchou] [:echou]]

cc Gallery expert djf and the owner of Bluetooth file transfer Ian Liu.

Comment 3

[Nick Davidson]

Regression window:

Works correctly on 
Buri v1.2 MOZ RIL
Build ID: 20130904040205
Gecko: http://hg.mozilla.org/mozilla-central/rev/7ff96bd19c1c
Gaia: b6c5bf1d24230bfed4a8f680e625fa2175001f82
Platform Version: 26.0a1

September 5-6 builds had no preview just a black screen

Environmental  Variables:
Build ID: 20130905185329
Gecko: http://hg.mozilla.org/mozilla-central/rev/df8f342e9a6b
Gaia: b77dc7d399c14ac2bafe5c89566b292bc6772d32
Platform Version: 26.0a1

In Builds from September 9 till now - user will get picture zoomed-in, in upper left corner during preview. (It is not only happen when user receives pic over Bluetooth but also if user opens picture attachment from email)

Build it started on Environmental  Variables:
Buri v1.2 moz ril
Build ID: 20130909114657
Gecko: http://hg.mozilla.org/mozilla-central/rev/218d4334d29e
Gaia: aa4180e9286d385fa6b62d236f30fb24cd8b93e9
Platform Version: 26.0a1

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

This looks like another regression with the patch of bug 900425 and bug 907965. The correct way to call displayImage after that patch should be [1]. But in open.js, it uses the old way to call displayImage[2].

needing info from tom.


[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/gallery/js/frames.js#L331-L337
[2] https://github.com/mozilla-b2g/gaia/blob/master/apps/gallery/js/open.js#L113-L160

Comment 5

[Tom Herold]

Attachment: Github Pull Request

Comment 6

[Tom Herold]

Attachment: Github Pull Request

Comment 7

[Tom Herold]

Attachment: Github Pull Request

Comment 8

[David Flanagan [:djf]]

Comment on attachment 810671 [details]
Github Pull Request

r+ if you fix the issues noted on github and test it carefully. (Let me know if you are unable to test bluetooth file transfer from your desktop to your phone).

In particular, please test with the EXIF orientation test images to make sure that they are displayed correctly.

Comment 9

[David Flanagan [:djf]]

Landed to master: https://github.com/mozilla-b2g/gaia/commit/e19bcb49cb6463c9284d26f7df1e3e5c4c3cdcac

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted e19bcb49cb6463c9284d26f7df1e3e5c4c3cdcac to:
v1.2: 5bf71fa908a34ddb56f49cdd964815e1e52f8bbc