917409 - Trailing spaces on Soundcloud URLs are not stripped

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Chris DeCairos (:cade)]

This is causing a lot of trouble.

STR:

1. add "https://soundcloud.com/offspring/americana " with the trailing space
2. add the clip to your project. it will not load.

Comment 1

[Matthew Schranz [:mjschranz]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/209

Comment 2

[Scott [:thecount] Downe]

Comment on attachment 806115 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/209

Does not work on projects that were previously saved with trailing spaces.

Also does not work when added view the editor.

It gets more complicated too, as in the cases where it was saved incorectly, the source looks like this: 
["https://soundcloud.com/zedd/zedd-legend-of-zelda-original ?butteruid=1379442881010", ""]

It has a trailing empty source, it should not.

The space is between the url and ?butteruid, so trim is never going to catch it.

It should not have a butteruid anyway.

Comment 3

[Matthew Schranz [:mjschranz]]

Comment on attachment 806115 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/209

Fixed up.

Comment 4

[Scott [:thecount] Downe]

Comment on attachment 806115 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/209

Does not fix the track event if saved in the project before this fix.

Comment 5

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/212

Needed to get this off my mind. It was bugging me and you seemed busier than I.

R+ on your commit plus mine.

Comment 6

[Matthew Schranz [:mjschranz]]

Comment on attachment 806115 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/209

Updated. You missed the trim in your patch.

Comment 7

[Scott [:thecount] Downe]

Comment on attachment 806115 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/209

Looks good.

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/43f9d5b38362d03f0f9e55d451c6d9d1844609f3
Fix Bug 917409 - Trim trailing whitespace on urls passed into add clips