917426 - Multi-account error messages need layout/functionality work

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Justin Crawford [:hoosteeno] [:jcrawford]]

Error states in multi-accounts are not optimal. A couple minor things:

1) if you forget to choose an account type, the layout of the account field wraps vertically and the red doesn't surround the account-type dropdown. EXPECTED: the fields for a particular account are still aligned horizontally and the data missing is clearly identified.

2) if you have an error and click "add a field" before resolving the error, all of the new fields will copy the error field. EXPECTED: new fields created while there's an error on the screen will not be pre-populated with error status.

Comment 2

[Julia Elman]

Adding Bug #897722 as a dependency, since there are some new layouts that will determine the new layout of the error messages on the multi-account fields.

Comment 3

[Julia Elman]

Pull request submitted here: https://github.com/mozilla/mozillians/pull/666

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/61d701f9c031ea255bb3c7b04d500ffa982bc17a
[Fix Bug 917426] Fix error message placement and duplication on account fields.

https://github.com/mozilla/mozillians/commit/ad8b4bb9b39190ce07f02d645630a5e9f59fdfdd
Merge pull request #666 from juliaelman/917426-fix-multi-acct-errors

[Fix Bug 917426] Fix error message placement and duplication on account fields.

Comment 5

[Giorgos Logiotatidis [:giorgos]]

We removed the error but we forgot to remove the red border when adding new a new row.

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/210c63919b4272772342fbc6af353b15d515fba5
[fix bug 917426] Remove error class on new ExternalAccount.

Comment 7

[Giorgos Logiotatidis [:giorgos]]

Verified on stage! Thanks Julia :)