Closed Bug 917437 Opened 12 years ago Closed 12 years ago

Disable or change the "This page was made with the ..." <div> insertion

Categories

(Webmaker Graveyard :: X-Ray Goggles, defect)

All
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: info, Unassigned)

Details

User Agent: Mozilla/5.0 (Windows NT 6.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/29.0.1547.66 Safari/537.36 Steps to reproduce: To experiment with Transparent overlays on gifdrift.biz I use http://fffff.at/occupy/ to add a div widget overlay to gifdrift.biz I amend the HTML code of the widget to be replaced with one large transparent gif: http://stephenfortune.net/tumblr/octopi_4.gif The code I have attempted is as follows CODE EG 1 <div id="occupy-widget-wrapper" style="position: absolute; top: 4px; width: 100%; height: 800px; class=" "="" class=""> <img src="http://stephenfortune.net/tumblr/octopi_4.gif" align="middle"> </div> CODE EG 2 <div id="occupy-widget-wrapper" style = "position: fixed; top:0; width: 100%; height: 800px; class=" "="" class=""> <img src="http://stephenfortune.net/tumblr/octopi_4.gif" align="middle"> </div> Actual results: When I publish my remix the addition of this code <div style="position: absolute; top: 0; left: 0; right: 0; height: 1.4em; background: black; z-index: 999999; text-align: center; color: white; opacity: 0.6;">This page was made with the <a class="goggles" href="https://goggles.webmaker.org/" style="color: white!important; text-decoration: underline!important;">Web X-Ray Goggles</a>, part of the <a href="https://webmaker.org/" style="color: white!important; text-decoration: underline!important;">Mozilla Webmaker</a> toolkit.</div> destroys the layout of the overlay I am trying to put over the website Expected results: The end result should look like this http://www.youtube.com/watch?v=xqb6044CtWU Instead the outcome looks like this CODE EG 1 http://stephenfortune.makes.org/goggles/stephenfortunes-remix-of-occupying-wwwgifdriftbiz- CODE EG 2 http://stephenfortune.makes.org/goggles/stephenfortunes-remix-of-occupying-wwwgifdriftbiz--4
OS: All → Windows 7
The hack I've utilised allows Goggles remixes of websites whose main content is either entirely iframe based or websites composed of DIV elements which return "that element is too big to remix, try selecting a smaller one"
I do not know javascript well enough to reverse engineer the goggles bookmarklet. Can the javascript of the Goggles bookmarklet be amended, or an alternate version of some of the .js scripts be provided to the me (and the other webmakers), which does not contain the HTML that puts the "This page was made with the ..." <div> insertion as the top <div> on a published goggles remix javascript:(function(){var%20script=document.createElement('script');script.src='https://goggles.webmaker.org/en-US/webxray.js';script.className='webxray';script.dataset.lang='en-US';script.dataset.baseuri='https://goggles.webmaker.org/en-US';document.body.appendChild(script);})()javascript:(function(){var%20script=document.createElement('script');script.src='https://goggles.webmaker.org/en-US/webxray.js';script.className='webxray';script.dataset.lang='en-US';script.dataset.baseuri='https://goggles.webmaker.org/en-US';document.body.appendChild(script);})();;
we can't just take it out without making it really easy to create goggle hacks that look like another site to trick people less familiar with the web into thinking they're the real deal. That notice needs to stay on goggle-hacked pages as a human safety measure, as well as to allow people to discover the tools it was made with. That said, you can use thimble for more complex hacks, or you can give your own overlay a z-index higher than 999999 and it'll sit on top of the goggle notification. It also looks like your second comment is a different issue, can you file that separately?
Status: UNCONFIRMED → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.