917453 - Unable to install a listed-as-free app from staging - "You have not purchased this app"

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Payments/Refunds, defect, P1)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Gecko: 6565d51b22a1ce191e18e923f0777723f73688a3
Gaia: 054cdc27404e2daca91d3065d9783681032b2151
Branch: 1.0.1
Device: Inari, engineering build
Carrier: AT&T, 2G/EDGE

STR:

1. Install and load Marketplace staging
2. Log in with Persona
3. Try to install the free app https://marketplace.allizom.org/app/test-app-risauopuylus?src=search

Actual Results:

E/GeckoConsole(  479): Content JS LOG at https://marketplace-cdn.allizom.org/media/fireplace/js/include.js?b=1deed3d-5237663f:5 in anonymous: [model] Found app with lookup key test-app-risauopuylus
E/GeckoConsole(  479): Content JS LOG at https://marketplace-cdn.allizom.org/media/fireplace/js/include.js?b=1deed3d-5237663f:5 in anonymous: [buttons] Install requested for Test App (risauopuylus)
E/GeckoConsole(  479): Content JS LOG at https://marketplace-cdn.allizom.org/media/fireplace/js/include.js?b=1deed3d-5237663f:5 in anonymous: [buttons] Starting app installation for Test App (risauopuylus)
E/GeckoConsole(  479): Content JS LOG at https://marketplace-cdn.allizom.org/media/fireplace/js/include.js?b=1deed3d-5237663f:5 in anonymous: [req] POSTing https://marketplace.allizom.org/api/v1/receipts/install/?_user=---&carrier=telefonica&dev=firefoxos&device=firefoxos&lang=en-US&pro=1f7feffb839b.45.2&region=us

<snip>

E/GeckoConsole(  479): Content JS LOG at https://marketplace-cdn.allizom.org/media/fireplace/js/include.js?b=1deed3d-5237663f:5 in anonymous: [req] Request failed: POST 402
E/GeckoConsole(  479): Content JS LOG at https://marketplace-cdn.allizom.org/media/fireplace/js/include.js?b=1deed3d-5237663f:5 in anonymous: [req] Response data:  {"reason": "You have not purchased this app."}
E/GeckoConsole(  479): Content JS ERROR at https://marketplace-cdn.allizom.org/media/fireplace/js/include.js?b=1deed3d-5237663f:5 in anonymous: [buttons] Could not generate receipt or record install for Test App (risauopuylus)
E/GeckoConsole(  479): Content JS LOG at https://marketplace-cdn.allizom.org/media/fireplace/js/include.js?b=1deed3d-5237663f:5 in anonymous: [buttons] Unsuccessful install for Test App (risauopuylus)

Comment 1

[Stuart Colville [:muffinresearch]]

In the api https://marketplace.allizom.org/api/v1/apps/app/test-app-risauopuylus/ response for this app the price and price_locale are shown as null.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

FWIW, I'm able to install https://marketplace.allizom.org/app/test-app-fireplacesadsadase?src=search

E/GeckoConsole(  479): Content JS LOG at https://marketplace-cdn.allizom.org/media/fireplace/js/include.js?b=1deed3d-5237663f:5 in anonymous: [apps] App installed successfully: Test App (Fireplacesadsadaseee)

Comment 3

[Kumar McMillan [:kumar]]

P1 until we decide otherwise. This seems to affect all $0 apps. Might be related to: https://github.com/mozilla/zamboni/commit/59d0e8c2b66f1bbb2d6a88a3b4d2c10362c07731

Comment 4

[Kumar McMillan [:kumar]]

hmm, can't really reproduce it with a freshly uploaded app. When not logged in I do see a 500:

ValueError Cannot assign None: "AddonPurchase.user" does not allow null values.
http://sentry.dmz.phx1.mozilla.com/addons/marketplace-stage/group/15446/

When logged in, I don't get any error.

Comment 5

[Kumar McMillan [:kumar]]

The app stephen used in STR was created in Feb 2013 so I think it has bitrotted (we don't set up $0 apps the same way anymore). Looks like the command from bug 895937 wiped out its premium object. I'm pretty sure we can ignore that error though. It doesn't happen for new apps.

The exception in comment #4 is a little more confusing. It's refusing to let an anonymous user install a $0 app. How did that ever work?! I think something in Fireplace or the API is broken -- it's no longer prompting a login before trying to download a $0 app

Comment 6

[Kumar McMillan [:kumar]]

Since the original STR is about an old app that has cruft in it I don't think we need to try and fix it. However, free apps are still broken. See bug 917601

Comment 7

[Christopher Van Wiemeersch [:cvan]]

I really hope the app in comment 0 is wrong because https://marketplace.allizom.org/app/test-app-risauopuylus/ is a paid app that has price=null and payment_required=false, which means it won't get flagged as "Unavailable" and the button will say "Free" instead: https://github.com/mozilla/fireplace/blob/master/hearth/media/js/apps.js#L122-124

Comment 8

[Andy McKay]

(In reply to Stuart Colville [:scolville] from comment #1)
> In the api
> https://marketplace.allizom.org/api/v1/apps/app/test-app-risauopuylus/
> response for this app the price and price_locale are shown as null.

As noted in the docs, price == null means that app cannot be bought in your region.

http://firefox-marketplace-api.readthedocs.org/en/latest/topics/apps.html

In this case the app is premium but has no premium object. It was last modified in Feb 2013. I'm not sure if that's a result of the changes or the app being broken.

Comment 9

[Stuart Colville [:muffinresearch]]

(In reply to Andy McKay [:andym] from comment #8)
> (In reply to Stuart Colville [:scolville] from comment #1)
> > In the api
> > https://marketplace.allizom.org/api/v1/apps/app/test-app-risauopuylus/
> > response for this app the price and price_locale are shown as null.
> 
> As noted in the docs, price == null means that app cannot be bought in your
> region.
> 
> http://firefox-marketplace-api.readthedocs.org/en/latest/topics/apps.html
> 
> In this case the app is premium but has no premium object. It was last
> modified in Feb 2013. I'm not sure if that's a result of the changes or the
> app being broken.

Ah right, thanks for clarifying - it was confusing that this had no premium object but due to the age of the app it sounds like this was just misleading.