917465 - [Email] launching a mail notification will cause Email app to spin and load forever

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Tony Chung [:tchung]]

Attachment: logcat of no email launch

when tapping the incoming mail notification, it tends to launch into email app but just sit there and spin forever, never loading the content on the screen.   Attached a full logcat.

Tried this with both a gmail and yahoo IMAP account.   Full logcat attached.

Repro:
1) install 1.2 nightly build 
2) setup yahoo and/or gmail accounts.  set up receive notifications, and shorten the sync interval.
3) send emails to both accounts from other sources
4) new email notifications appear.  open status bar and tap on it.
5) Verify it sits and spins forever trying to launch the email that you want to view.  it never actually loads.

Expected:
- email is opened on notifications and viewed in app

ActuL;
- email never launches, the app just spins forever

Comment 1

[Dylan Oliver [:doliver]]

triage: blocking for bug on new 1.2 feature

Comment 2

[Dylan Oliver [:doliver]]

Evan, did you intentionally remove the koi+ for this bug?

Comment 3

[Evan Tseng [:evanxd]]

Hi Dylan,

Sorry, it might be an accident.
I didn't know I did that.

Comment 4

[Dylan Oliver [:doliver]]

Dylan Oliver deleted the linked story in Pivotal Tracker

Comment 5

[James Burke [:jrburke]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12523

Pointer to Github pull-request

Comment 6

[James Burke [:jrburke]]

Comment on attachment 811410 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12523

The issue was my poor understanding of notification API: it triggers mozSetMessageHandler listeners for every notification closed. So what was happening:

* email is sent to two email addresses, both configured to be syncing messages.
* this results in two notifications, one for each account.
* one notification is clicked.
* due to an implementation detail in the system notification code, it also then closes all notifications for associated with the app that gets the notification click.
* This results in the system firing three events to the 'notification' message handler in the email app: one for the click and two close notifications.

I should have been checking message.clicked to know if the message handler notification was from a click or a close, and not do the goofy notifyId checking I was doing before. The notifyId checking was added because I saw to message handler events when testing with one account configured. Turns out the second was the "onclose" message. The notifyId setup was not sufficient with these three events because the third event is for a close of an unrelated notification. This caused the bug.

So the fix is: check for message.clicked, and only do work in those cases. I then removed the hacky notifyId stuff, and then updated the integration test to pass .clicked to operate correctly. I also fixed a bad assumption in email_sync test code, and updated the tests to use email_sync's setup() to do the message handler mock injection.

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 811410 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12523

r=asuth based on inspection and green travis run and minimal deltas.  Experiencing device issues so I haven't run on the device and jrburke has indicated he ran device tests, so I think we're good.

Comment 8

[James Burke [:jrburke]]

Merged in Gaia master:
https://github.com/mozilla-b2g/gaia/commit/94d358f8cb17fdbcf9fc0c0392e393677db8af6d

from pull request:
https://github.com/mozilla-b2g/gaia/pull/12523

Comment 9

[James Lal [:lightsofapollo]]

Uplifted 94d358f8cb17fdbcf9fc0c0392e393677db8af6d to:
v1.2: 669e9ed9016eb91bb89b6793578cd72537578791

Comment 10

[Allen Maxwell]

Multiple notifications displayed in notification window, when one notification is selected user is taken to the selected email message. All email account notifications, for this email message, are also satisfied from this single selection for all email accounts. 

Tested with email set-up for yahoo, gmail, hotmail, and outlook in auto/manual setup methods.

Buri v1.2 Mozilla RIL
Gaia   922de46ad5e4a8b513b24233a7f3bc54b93e9612
SourceStamp 2664ac296982
BuildID 20131018004000
Version 26.0a2
Base Image: 20131015

Comment 11

[William Hsu [:whsu]]

--------- Change the status to "VERIFIED" ---------