Closed
Bug 917483
Opened 11 years ago
Closed 11 years ago
Bug.update_attachment causes error when updating filename using key 'file_name'
Categories
(Bugzilla :: WebService, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 5.0
People
(Reporter: dkl, Assigned: dkl)
References
Details
Attachments
(1 file)
|
2.16 KB,
patch
|
mail
:
review+
|
Details | Diff | Splinter Review |
When I was reviewing this new feature I failed to test the changing of the file name. The documentation states to use 'file_name' as the parameter but internally it is 'filename'. So I get the error: The requested method 'Bugzilla::Attachment::set_file_name' was not found. I will create a patch that converts 'file_name' to 'filename' before set_all() so that we can keep the param naming for attachments consistent. dkl
|
||
Comment 1•11 years ago
|
||
+1 for this. This should be the same name for add_attachment and update_attachment. Please change this or correct the POD!
|
Assignee | |
Comment 2•11 years ago
|
||
|
||
Updated•11 years ago
|
Attachment #806225 -
Flags: review?(simon) → review+
|
|
||
Updated•11 years ago
|
Flags: approval?
|
|
||
Updated•11 years ago
|
Flags: approval? → approval+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bugzilla/trunk modified Bugzilla/WebService/Bug.pm Committed revision 8762.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•