Closed
Bug 91751
Opened 23 years ago
Closed 23 years ago
In Search Messages, `Search' should look like the default button
Categories
(SeaMonkey :: MailNews: Message Display, defect)
SeaMonkey
MailNews: Message Display
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.5
People
(Reporter: mpt, Assigned: bhart)
References
()
Details
(Whiteboard: PDT+)
Attachments
(2 files)
|
920 bytes,
patch
|
hwaara
:
review+
sspitzer
:
superreview+
|
Details | Diff | Splinter Review |
|
23.90 KB,
image/gif
|
Details |
Screenshot
Build: 2001072008, Mac OS 9.1
To reproduce:
1. In mail/news, open the Search Messages window.
2. Look at the `Search' button.
What you should see:
* A button with a border around it indicating that it is the default button
(i.e. that it reacts to the Enter key).
What you actually see:
* A button which looks like any other.
|
||
Comment 1•23 years ago
|
||
Reassign
Assignee: naving → hwaara
OS: Mac System 9.x → All
Hardware: Macintosh → All
|
|
||
Updated•23 years ago
|
Target Milestone: --- → mozilla0.9.3
|
|
||
Updated•23 years ago
|
Target Milestone: mozilla0.9.3 → mozilla0.9.4
|
|
||
Updated•23 years ago
|
Target Milestone: mozilla0.9.4 → mozilla1.0
|
Assignee | |
Comment 2•23 years ago
|
||
Can't see why this wouldn't be desired, but since in other dialog our buttons
are defaulted, is this fine, Jennifer? The spec currently doesn't have it
highlighted by default. Here's a screenshot of the patch in my tree. If
Jennifer approves, r=stephend@netscape.com. Thanks, Bradley.
|
|
||
Comment 6•23 years ago
|
||
Please keep me on the CC list when reassigning. Thanks.
|
|
||
Comment 7•23 years ago
|
||
Comment on attachment 49547 [details] [diff] [review]
patch to make "search" the default button
r=hwaara
Attachment #49547 -
Flags: review+
|
||
Comment 9•23 years ago
|
||
Comment on attachment 49547 [details] [diff] [review]
patch to make "search" the default button
sr=sspitzer
Attachment #49547 -
Flags: superreview+
Fixed on trunk. If anyone wants this for branch, re-open, and put nsbranch in
the keyword field.
Meant to mark it fixed.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
||
Comment 12•23 years ago
|
||
minor polish issue to give the search button the highlight when it is the
default button in the dialog.
Status: RESOLVED → REOPENED
Keywords: nsbranch+
Resolution: FIXED → ---
Target Milestone: mozilla1.0 → mozilla0.9.5
|
||
Comment 13•23 years ago
|
||
Looks like a small safe patch, with some user upside. Pls bring it to PDT
tomorrow @ noon for review.
|
|
||
Comment 15•23 years ago
|
||
I just checked this into the branch.
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
|
||
Comment 16•23 years ago
|
||
OK in the sep19 0.9.4 commercial branch build: win98, linux rh6.2, mac OS 9.1,
OS X. Modern skin shows search button as default like the attached screenshot.
Classic skin shows search button as other dialogs' default buttons.
Verified in branch. Will check the trunk.
Keywords: vtrunk
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
Component: MailNews: Search → MailNews: Message Display
QA Contact: laurel → search
You need to log in
before you can comment on or make changes to this bug.
Description
•