917537 - Turn back on modify_event_test.js it was disabled because of intermittent failures

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Comment 1

[Miller Medeiros [:millermedeiros]]

this starting to "block" other bugs (like Bug 966516), so I think we should raise the priority. Maybe I can take a look during this week (still unsure what will be my next task).

Comment 2

[Kevin Grandon :kgrandon]

Perhaps this was due to a timeout and is ok now? We went through and increased the default timeout for all tests.

Comment 3

[Miller Medeiros [:millermedeiros]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16052

I executed the tests MANY times and was not able to reproduce errors on Travis or locally. I guess it was indeed related to timeouts or something else changed in the past months.

Comment 4

[Gareth Aye [:gaye] (back from PTO)]

https://github.com/mozilla-b2g/gaia/commit/539b616b8286756e6168313e5672482221cb3757

Comment 5

[Kevin Grandon :kgrandon]

Unfortunately this has been slightly intermittent since this landed, my estimate is a ~2-3% failure rate. I've disabled the test again: https://github.com/mozilla-b2g/gaia/commit/5a94e70aaa2e38617d4cf7fc56d1ab445043493b

Failure details:

1) [calendar] Views.ModifyEvent #save create with provider that can create:

Error: updated model: property equality for (alarms) : expected [ { action: 'DISPLAY', trigger: -300 } ] to equal []

at chaiAssert (http://calendar.gaiamobile.org:8080/common/test/helper.js:33:1)

at eql (http://calendar.gaiamobile.org:8080/common/vendor/chai/chai.js:530:1)

at deepEqual (http://calendar.gaiamobile.org:8080/common/vendor/chai/chai.js:1331:5)

at chai_hasProperties (http://calendar.gaiamobile.org:8080/test/unit/setup.js:275:1)

at (anonymous) (http://calendar.gaiamobile.org:8080/test/unit/views/modify_event_test.js:760:13)

at (anonymous) (http://calendar.gaiamobile.org:8080/common/test/mocha_generators.js:40:15)

at createEvent (http://calendar.gaiamobile.org:8080/test/unit/views/modify_event_test.js:755:11)

at persistEvent (http://calendar.gaiamobile.org:8080/js/views/modify_event.js:328:9)

at verifyCaps (http://calendar.gaiamobile.org:8080/js/views/modify_event.js:314:11)

at (anonymous) (http://calendar.gaiamobile.org:8080/test/unit/support/mock_provider.js:213:9)

at handleNextTick (http://calendar.gaiamobile.org:8080/js/calendar.js:177:10)

Comment 6

[Miller Medeiros [:millermedeiros]]

to be honest, I think we should delete most of the unit tests for the modify event view and/or rewrite them.. these tests are really complex to understand and most of the things are easily tested with marionette tests (eg. default reminder values, if data is being saved properly, if it updates UI based on DOM events, etc)

there are some things that are still easier to test with unit tests, like: when a new calendar is added, error handling (specially related to providers); so we should keep unit tests for these.

I'm currently working on Bug 1089589 and ended up writing marionette tests covering all the reminders logic, and was way simpler than if I had to do the same thing with unit tests.

Comment 7

[Armen [:armenzg]]

Closing all intermittent test failures for Firefox OS (since we're not focusing on it anymore).

Please reopen if my search included your bug by mistake.

Comment 8

[BMO Automation]

Firefox OS is not being worked on