Add a robocop.ini manifest for x86

RESOLVED FIXED in Firefox 27

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: gbrown, Assigned: gbrown)

Tracking

unspecified
Firefox 27
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments)

I have been hoping that we could use a single manifest for robocop, but we have a couple of tests crashing on x86 only and at least one intermittent failure that occurs much more frequently on x86. I imagine the crashes will be sorted out in a few weeks (delayed because we cannot currently get crash dumps) but differing frequencies of intermittent failures could be a long-term issue.
Adds the x86-specific robocop.ini file, with x86-failing tests disabled.

$ diff robocop.ini robocop_x86.ini
5c5
< [testBookmarkKeyword]
---
> # [testBookmarkKeyword] # frequent fail on x86 only; see bug 915350
36c36
< [testSystemPages]
---
> # [testSystemPages] # crash on x86 only; see bug 907383
40c40
< [testFindInPage]
---
> # [testFindInPage] # crash on x86 only; see bug 907303

Once this lands, we can update the mozharness x86 script to point to the new manifest and turn robocop green.
Attachment #806270 - Flags: review?(jmaher)
can we skip these via the manifest support instead?
Comment on attachment 806270 [details] [diff] [review]
add robocop_x86.ini

Review of attachment 806270 [details] [diff] [review]:
-----------------------------------------------------------------

I see nothing wrong with this manifest.
Attachment #806270 - Flags: review?(jmaher) → review+
(In reply to Joel Maher (:jmaher) from comment #2)
> can we skip these via the manifest support instead?

Sorry, I missed this earlier...and I'm not sure I understand.

afaik, the robocop manifest does not allow for skip-if/fail-if.
Whiteboard: [leave open]
Attachment #806805 - Flags: review?(armenzg)
Comment on attachment 806805 [details] [diff] [review]
use robocop_x86.ini

Review of attachment 806805 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!
After you land this, if a Cedar job is not using your revision of mozharness you can just re-trigger.
Attachment #806805 - Flags: review?(armenzg) → review+
https://hg.mozilla.org/build/mozharness/rev/de5fafe78778
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [leave open]
I forgot to update the Makefiles.

https://tbpl.mozilla.org/php/getParsedLog.php?id=28054773&tree=Cedar&full=1

13:23:08     INFO - Mochi-Remote ERROR | Unable to find specified robocop .ini manifest 'robocop_x86.ini'
13:23:08     INFO - Mochi-Remote ERROR | Invalid options specified, use --help for a list of valid options
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 806978 [details] [diff] [review]
add new manifest to makefiles

Review of attachment 806978 [details] [diff] [review]:
-----------------------------------------------------------------

You don't need my review to add files to existing lists.
Attachment #806978 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/0172bbcf8903
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
This hasn't really worked out. It is easy to update either robocop.ini or robocop_x86.ini and forget to update the other one. 

Now Robocop understands skip-if in manifests -- let's use that feature instead and eliminate robocop_x86.ini
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #815916 - Flags: review?(armenzg) → review+
Comment on attachment 815917 [details] [diff] [review]
remove robocop_x86.ini and use skip-if in robocop.ini

Review of attachment 815917 [details] [diff] [review]:
-----------------------------------------------------------------

oh this makes me happy
Attachment #815917 - Flags: review?(jmaher) → review+
https://hg.mozilla.org/build/mozharness/rev/b4cabe359fad

I want to generate some test failures (like testSystemPages) on Cedar/x86...then I'll push the m-c changes to green up robocop on x86 again.
something here is in mozharness production
https://hg.mozilla.org/mozilla-central/rev/a03b6f30006f
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Blocks: 936226
You need to log in before you can comment on or make changes to this bug.