Closed Bug 917590 Opened 6 years ago Closed 6 years ago

Remove most roots and handles in IonBuilder

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: bhackett, Assigned: bhackett)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Bug 785905 requires that IonBuilder not be able to access a JSContext, which is currently used for rooting lots of things in the compiler.  Since the builder already runs in an AutoSuppressGC context these roots are all unnecessary, and removing them is simple except for cases where the compiler calls out to other parts of the VM which require handles.  The attached patch removes the simple roots, leaving just the ones involved in such VM calls.
Attachment #806323 - Flags: review?(jdemooij)
Comment on attachment 806323 [details] [diff] [review]
patch

Review of attachment 806323 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #806323 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/2b0a593b3c6c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Assignee: general → bhackett1024
You need to log in before you can comment on or make changes to this bug.