917590 - Remove most roots and handles in IonBuilder

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Brian Hackett [Laid off!]]

Attachment: patch

Bug 785905 requires that IonBuilder not be able to access a JSContext, which is currently used for rooting lots of things in the compiler.  Since the builder already runs in an AutoSuppressGC context these roots are all unnecessary, and removing them is simple except for cases where the compiler calls out to other parts of the VM which require handles.  The attached patch removes the simple roots, leaving just the ones involved in such VM calls.

Comment 1

[Jan de Mooij [:jandem]]

Comment on attachment 806323 [details] [diff] [review]
patch

Review of attachment 806323 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

Comment 2

[Brian Hackett [Laid off!]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2b0a593b3c6c

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2b0a593b3c6c