Closed
Bug 917590
Opened 11 years ago
Closed 11 years ago
Remove most roots and handles in IonBuilder
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
Attachments
(1 file)
|
84.85 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
Bug 785905 requires that IonBuilder not be able to access a JSContext, which is currently used for rooting lots of things in the compiler. Since the builder already runs in an AutoSuppressGC context these roots are all unnecessary, and removing them is simple except for cases where the compiler calls out to other parts of the VM which require handles. The attached patch removes the simple roots, leaving just the ones involved in such VM calls.
Attachment #806323 -
Flags: review?(jdemooij)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 806323 [details] [diff] [review]
patch
Review of attachment 806323 [details] [diff] [review]:
-----------------------------------------------------------------
Nice.
Attachment #806323 -
Flags: review?(jdemooij) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
|
||
Updated•11 years ago
|
Assignee: general → bhackett1024
You need to log in
before you can comment on or make changes to this bug.
Description
•