917777 - Control + A for selecting everything is not working

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Description

[Leo Unglaub]

You cannot select the entire content of the console input field by pressing the normal shortcus Control + A. It simply is doing nothing. But thats a problem, because sometimes you just want to clear the entire input field.

Comment 1

[Mihai Sucan [:msucan]]

Thank you for the bug report. Ctrl-A/E are working as expected on Linux. We had this discussion previously in bug 623749.

(leaving open until the next web console bugs triage when we will decide if we want to change this behavior or not)

Comment 2

[Leo Unglaub]

In my opinion this is a bug. Because for jumping to the first/last position of the input field you already habe the "pos1" and "end" key on your keyboard. Also the field down there is not a reall command line, so the comparison to the linux terminal is not correct.

In every input element CTRL+A ist select all. Why try to change it in this case?

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

The team discussed this and consensus was to keep the existing behavior. FWIW you can use Ctrl-Shift-A to Select All on Linux.

Comment 4

[Paul Rouget [:paul]]

I'm going to be the annoying guy here :)

Re-opening because this behavior always seriously bugged me.

(In reply to Leo Unglaub from comment #2)
> In every input element CTRL+A ist select all. Why try to change it in this
> case?

I agree. Even in other browsers Ctrl-A selects the line.

(In reply to Panos Astithas [:past] from comment #3)
> The team discussed this and consensus was to keep the existing behavior.

Can we re-discuss that?

Comment 5

[Rob Campbell [:rc] (:robcee)]

let's do this for windows only because those users have a HOME key to get to the beginning of the line.

Comment 6

[Paul Rouget [:paul]]

I want that for Linux :(

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Well, everyone can press some version of a Home key...  Windows and Linux machines tend to have an explicitly labelled key.  For Mac, Apple's extended keyboard has a Home key, or you can press Fn + Left Arrow to get the same thing.

Comment 8

[Paul Rouget [:paul]]

Attachment: ctrl-a

Comment 9

[Paul Rouget [:paul]]

Attachment: v1

https://tbpl.mozilla.org/?tree=Try&rev=4ef1b1a9bcea

Comment 10

[Mihai Sucan [:msucan]]

Comment on attachment 8336709 [details] [diff] [review]
v1

Review of attachment 8336709 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

::: browser/devtools/webconsole/webconsole.js
@@ +3984,5 @@
>            // control-a
>            this.clearCompletion();
>  
> +          if (Services.appinfo.OS != "Darwin") {
> +            // Allow Select All on Windows and Linux.

This is fine, but do we need to keep the code for this case (ctrl-a)? Afaik, ctrl-a is implemented natively on macs. Can you please check?

Comment 11

[Paul Rouget [:paul]]

(In reply to Mihai Sucan [:msucan] from comment #10)
> This is fine, but do we need to keep the code for this case (ctrl-a)? Afaik,
> ctrl-a is implemented natively on macs. Can you please check?

You're right.

Comment 12

[Paul Rouget [:paul]]

Attachment: v2

Comment 13

[Mihai Sucan [:msucan]]

Comment on attachment 8336735 [details] [diff] [review]
v2

Thanks!

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/437b05dda7ca

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/437b05dda7ca