917791 - Increase pan / fling refresh rates for metrofx

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Pan and Zoom, defect)

Description

[Jim Mathies [:jimm]]

We have a couple constants here - gPanRepaintInterval (250 msec) and gFlingRepaintInterval (75 msec). Both seem rather high for metro (and in general). Changing these to more reasonable values (20 fps / 50 msec) really seems to smooth out our scrolling. Kats, any thoughts on this?

Comment 1

[Kartikaya Gupta (email:[e-mail])]

I think doing that makes sense for Metro because you're running on higher-powered devices than FFOS which is what these values were tuned for originally. Note that the values are preffed so it should be a simple matter to just adjust the prefs in the metro default prefs file.

Comment 2

[Jim Mathies [:jimm]]

Attachment: fix

Comment 3

[Jim Mathies [:jimm]]

Attachment: patch

prefs change for 20 fps scrolling

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 809121 [details] [diff] [review]
patch

Review of attachment 809121 [details] [diff] [review]:
-----------------------------------------------------------------

Fine by me :)

Comment 5

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7ec69b142816

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7ec69b142816

Comment 7

[Matt Brubeck (:mbrubeck)]

This change didn't actually take effect because of bug 936027.  Now that bug 936027 is fixed, we are actually using the new prefs, and it seems like a regression to me.  We are now painting several times more often (especially during flings) which seems to increase jank on my Surface Pro.  Should we revert to the original default values?

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Yeah I was seeing this too. We probably want to increase the interval at least, even if we don't revert back to the original defaults.

Comment 9

[Jim Mathies [:jimm]]

I'm not seeing any jank on an sp1, and the black rects problem has diminished as well. I can try adjusting the values and see what happens.