Closed
Bug 917830
Opened 12 years ago
Closed 12 years ago
[FM Radio] Use Full Line Highlights
Categories
(Firefox OS Graveyard :: Gaia::FMRadio, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: epang, Assigned: pivanov)
References
Details
(Whiteboard: visual design, visual-tracking, jian)
Attachments
(3 files, 1 obsolete file)
FMRadio.png
1. Use full width highlights (edge to edge) for active/pressed states.
2. Update highlight color to #348c9e.
|
Reporter | |
Updated•12 years ago
|
Summary: [Call Log] Use Full Line Highlights → [FM Radio] Use Full Line Highlights
|
|
Reporter | |
Comment 1•12 years ago
|
||
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #808288 -
Flags: feedback?(epang)
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
|
Reporter | |
Comment 4•12 years ago
|
||
(In reply to Pavel Ivanov [:ivanovpavel] from comment #2)
> Created attachment 808288 [details]
> After patch screenshot
Hi Pavel, same as clock something looks off with the highlight color/opacity. Can you check if these are the settings being used? thx!
#348c9e
60% Opacity
Flags: needinfo?(pivanov)
|
|
Assignee | |
Comment 5•12 years ago
|
||
Same here ... I used only #348c9e without opacity ... I will change it. Thanks :)
Flags: needinfo?(pivanov)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #808288 -
Attachment is obsolete: true
Attachment #808288 -
Flags: feedback?(epang)
|
|
Assignee | |
Comment 6•12 years ago
|
||
Attachment #808993 -
Flags: feedback?(epang)
|
|
Reporter | |
Comment 7•12 years ago
|
||
Comment on attachment 808993 [details]
After patch screenshot (desktop)
Awesome, great work :)
Attachment #808993 -
Flags: feedback?(epang) → feedback+
|
|
Assignee | |
Updated•12 years ago
|
Attachment #808290 -
Flags: review?(sjochimek)
|
|
||
Comment 8•12 years ago
|
||
Comment on attachment 808290 [details]
patch for Gaia/master
Landed in master: https://github.com/mozilla-b2g/gaia/commit/9b540d57eadd5644774fb0a1c6e3f16bb44b1272
Attachment #808290 -
Flags: review?(sjochimek) → review+
|
|
||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•12 years ago
|
Whiteboard: visual design, visual-tracking → visual design, visual-tracking, jian
Flags: in-moztrap+
You need to log in
before you can comment on or make changes to this bug.
Description
•