917835 - [Clock] Timer does not honor settings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Mike Pennisi [:jugglinmike]]

Steps to reproduce:

1. Navigate to the "Timer" panel
2. Select a sound
3. Disable Vibration
4. Press "Start"

Expected: When the timer event occurs, the specified sound is played and the device does not vibrate.

Actual: When the timer event occurs, no sound is played and the device vibrates.

Comment 1

[Corey Frang [:gnarf]]

Attachment: patch v1

Comment 2

[Corey Frang [:gnarf]]

Attachment: patch v2

rebased on top of current master

Comment 3

[Mike Pennisi [:jugglinmike]]

Comment on attachment 807927 [details] [diff] [review]
patch v2

Looks good to me! My favorite part?

$ grep TODO apps/clock/* -r | wc -l
6
$ git checkout gnarf-917835 
$ grep TODO apps/clock/* -r | wc -l
4

Comment 4

[Corey Frang [:gnarf]]

master: https://github.com/mozilla-b2g/gaia/commit/f70518eb4ecffd2611ddf912abe1f9127dd5f829

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/106683fcfda4

Comment 6

[Mike Pennisi [:jugglinmike]]

This patch depends on the refactoring introduced with bug 916774.

Comment 7

[Dylan Oliver [:doliver]]

triage: koi+ for incorrect functionality in new 1.2 feature

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted f70518eb4ecffd2611ddf912abe1f9127dd5f829 to:
v1.2: a0585387d5d1ebdac9ce5298c9ff360c91b9b292

Comment 9

[KTucker [:KTucker][Inactive 3/4/2016]]

Verified open on Buri Moz ril v1.2. 

Build ID: 20130924004002
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/b34384409be6
Gaia: a13c76f8d3c617ee57c302c103da04ed1a6298d1
Platform Version: 26.0a2

The phone still vibrates when the timer reaches "0" even though vibrate is turned off in settings. Should we log a new bug for this or re-open the issue?

Comment 10

[Corey Frang [:gnarf]]

I can't reproduce this on v1.2 branch, could you verify?

Comment 11

[KTucker [:KTucker][Inactive 3/4/2016]]

I can still reproduce this issue on today's Buri Moz ril v1.2 build.

Build ID: 20130925004005
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/fb764e648a8f
Gaia: b0e4a1333bb7bf0a749a384ba99e4f03f111e39a
Platform Version: 26.0a2

The phone still vibrates when the timer reaches "0" even though vibrate is turned off in settings.

Comment 12

[Corey Frang [:gnarf]]

I just checked out the same Gaia SHA on my checkout, did a `make install-gaia APP=clock`, and can not reproduce this.  There is no vibration when the timer reaches 0 after having turned off vibrate in the timer's options.

Are you talking about the "Vibrate" setting in the main "Sound" section of the Settings app?  Should this affect the value of the "Vibrate" option in the Timer?

If this is the case, this is definitely it's own bug.

Comment 13

[KTucker [:KTucker][Inactive 3/4/2016]]

I was talking about the "Vibrate" setting in the main "Sound" section of the Settings app. Closing this issue as fixed and researching the other issue.

Verified Fixed on Buri Moz Ril v1.2

Build ID: 20130925004005
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/fb764e648a8f
Gaia: b0e4a1333bb7bf0a749a384ba99e4f03f111e39a
Platform Version: 26.0a2

The phone does not vibrate when the timer reaches "0" if "Vibrate" is turned off on the timer page.