Handlify JS identifier APIs

RESOLVED FIXED in mozilla27

Status

()

RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: jonco, Assigned: jonco)

Tracking

({dev-doc-complete})

unspecified
mozilla27
dev-doc-complete
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 806802 [details] [diff] [review]
handlify-identifier-apis
Attachment #806802 - Flags: review?(wmccloskey)
Comment on attachment 806802 [details] [diff] [review]
handlify-identifier-apis

Review of attachment 806802 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/KeyPath.cpp
@@ +46,5 @@
>        return false;
>      }
>  
>      NS_ASSERTION(JSVAL_IS_STRING(stringVal), "This should never happen");
> +    JS::Rooted<JSString*> str(aCx, JSVAL_TO_STRING(stringVal));

Can you use .toString() instead?
Attachment #806802 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/mozilla-central/rev/70a765607344
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.