Closed Bug 917843 Opened 9 years ago Closed 9 years ago

Handlify JS identifier APIs

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: jonco, Assigned: jonco)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

No description provided.
Attachment #806802 - Flags: review?(wmccloskey)
Comment on attachment 806802 [details] [diff] [review]
handlify-identifier-apis

Review of attachment 806802 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/KeyPath.cpp
@@ +46,5 @@
>        return false;
>      }
>  
>      NS_ASSERTION(JSVAL_IS_STRING(stringVal), "This should never happen");
> +    JS::Rooted<JSString*> str(aCx, JSVAL_TO_STRING(stringVal));

Can you use .toString() instead?
Attachment #806802 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/mozilla-central/rev/70a765607344
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.