917885 - Minimize the #includes in xpcom/base

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

https://tbpl.mozilla.org/?tree=Try&rev=8443a98d562d

Comment 1

[(no longer active)]

https://tbpl.mozilla.org/?tree=Try&rev=7dca83ea02df

Comment 2

[(no longer active)]

https://tbpl.mozilla.org/?tree=Try&rev=24c210293b74

Comment 3

[(no longer active)]

https://tbpl.mozilla.org/?tree=Try&rev=3556b76d02aa

Comment 4

[(no longer active)]

https://tbpl.mozilla.org/?tree=Try&rev=7a38ed59e383

Comment 5

[Benjamin Smedberg]

Comment on attachment 806699 [details] [diff] [review]
Patch (v1)

As noted on IRC, the nsStringGlue thing is incorrect. nsStringGlue.h should only be used in xpcom/glue where code may be compiled against either the internal or external string API. Everywhere else should be using nsString.h directly.

Everything else looks good so I'm going to mark r+ for the rest of it.

Comment 6

[(no longer active)]

Pushed the wrong patch: https://hg.mozilla.org/integration/mozilla-inbound/rev/a8d6973e5743
Backed out: https://hg.mozilla.org/integration/mozilla-inbound/rev/8b6758f9e90f
and relanded: https://hg.mozilla.org/integration/mozilla-inbound/rev/b39cfce76d29

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b39cfce76d29