Closed Bug 917885 Opened 6 years ago Closed 6 years ago

Minimize the #includes in xpcom/base

Categories

(Core :: XPCOM, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: ehsan, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Comment on attachment 806699 [details] [diff] [review]
Patch (v1)

As noted on IRC, the nsStringGlue thing is incorrect. nsStringGlue.h should only be used in xpcom/glue where code may be compiled against either the internal or external string API. Everywhere else should be using nsString.h directly.

Everything else looks good so I'm going to mark r+ for the rest of it.
Attachment #806699 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/b39cfce76d29
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.