Closed
Bug 917983
Opened 11 years ago
Closed 11 years ago
BreakpointActor instances should be saved in the threadLifetimePool
Categories
(DevTools :: Debugger, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 28
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file)
|
6.70 KB,
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
...not in the connection's pool, which is hacky. When the thread goes away, the breakpoints should go away as well, so we are holding on to a bunch of stuff for longer than we need to. Unfortunately, we can't add BP actors to the threadLifetimePool until it actually lasts as long as the thread actor.
|
Assignee | |
Updated•11 years ago
|
Priority: -- → P3
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → nfitzgerald
|
|
Assignee | |
Comment 1•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=4b8d53e96bb5
Attachment #8343451 -
Flags: review?(past)
|
||
Updated•11 years ago
|
Attachment #8343451 -
Flags: review?(past) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/1fd3bf3cc55e
Whiteboard: [fixed-in-fx-team]
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1fd3bf3cc55e
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•