Closed
Bug 918016
Opened 11 years ago
Closed 11 years ago
Confirm GA script is getting added to all Makes our tools produce
Categories
(Webmaker Graveyard :: Metrics, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: humph, Assigned: jon)
References
Details
I just noticed that we don't seem to be adding the GA script anymore to Thimble makes. Can we fix that and also confirm our other tools are doing the right thing?
neither metatags nor GA is making it through on staging and production, but running locally on v0.1.6 there is absolutely no problem to be found. Continuing investigation.
So far, the only things we know are that it's not any of these things: - bad .env file - using the wrong template - testing on staging shows only one details.html file exising - using the wrong version - /healthcheck reports a version identical to latest tag on github, file system inspection shows identical file content for middleware.js and details.html A published page contains this header: <head> <title>Your Awesome Webpage created on Wed, 28 Aug 2013 18:29:15 GMT</title> <link rel="shortcut icon" href="/favicon.ico"> <link rel="stylesheet" href="/static/stylesheets/makedetails.css"> </head> The header section in details.html looks like this: <head> <meta charset="utf-8"> <title>{{TITLE}}</title> <link media="screen" rel="stylesheet" href="{{HOSTNAME}}/stylesheets/makedetails.css"> </head> These are very different. Looking for anything that uses the string "makedetails.css" only reveals details.html
starting to run out of ideas here. It's as if staging/prod use a completely different template, despite such a template not existing. If I testing publishing to S3 on v0.1.7 on localhost, the result is a correct publication with the metaTags and goggle analytics data baked in: view-source:http://s3.amazonaws.com/org.webmadecontent.staging.thimble/mopaxian/thimble/your-awesome-webpage-created-on-wed-18-sep-2013-220447-gmt The same code, with the same .env, on an EC2 instance, leads to different data being published.
example of a recent, bad, publication: https://monkeymagic.mywebmaker.org/thimble/this-is-test-ja-ja source: view-source:https://monkeymagic.mywebmaker.org/thimble/this-is-test-ja-ja
killing off the staging node and making a new one had no effect, which means we can pretty much rule out odd memory-based caching of an older details.html template.
jbuck: are we doing any kind of content rewriting when we're publishing into a bucket that's subject to user-domaining? I cannot find anything even remotely looking like the HTML skeleton that https://monkeymagic.mywebmaker.org/thimble/this-is-test-ja-ja (and everything else) uses for its content. Thimble never had a block like <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.9.1/jquery.min.js"></script> <script> var $toggle = $('.make-bar-expand-collapse'), $details = $('.make-details'), $arrow = $('img', $toggle), ... in its details.html, and popcorn from what I can tell doesn't either. Is this something that is introduced by scripts running on AWS for managing userdomain content?
Flags: needinfo?(jon)
we do, and it's disastrous -- https://github.com/mozilla/make-valet/blob/master/views/embed-shell.html reassigning =)
Assignee: pomax → jon
Assignee | ||
Updated•11 years ago
|
Flags: needinfo?(jon)
Comment 8•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/make-valet https://github.com/mozilla/make-valet/commit/bb38bb12a9a8bb35c3a4cee7c1a234783ab55b07 Bug 918016 - Add Google Analytics tracking code to embed shell
Assignee | ||
Comment 9•11 years ago
|
||
We're good on staging for GA, pushing to prod now: https://jon.mywebmaker.org/thimble/your-awesome-webpage-created-on-fri-20-sep-2013-100810-gmt
Assignee | ||
Comment 10•11 years ago
|
||
And we're good on prod too: https://nwp.makes.org/thimble/coding-with-the-new-york-times What sort of metatags need to be added? Looks like just og:url, og:updated_time, and og:site_name ?
Comment 11•11 years ago
|
||
Those are the three we had in thimble before, so I'd say add those in and then let's close this bug, leaving more opengraph tags for follow-up, if necessary
Assignee | ||
Comment 12•11 years ago
|
||
Closing this bug since the work is complete. I'll do the OG tags in another bug right now
Assignee | ||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•