918078 - Dumping the layer tree appears to have side-effects

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Stack of crash

I used BenWa's bug 916259 to try to dump the layer tree in B2G but because of where I put the log it was crashing. The stack trace shows it's running into an assertion failure in the middle of the dumping code. See attached stack.

Comment 1

[Nicolas Silva [:nical]]

Do we want the dump to contain dataurls of the texture data? If so we need to Lock the TextureHost before requiring and accessing the data on the TextureSource, which we are not doing here.

Otherwise we do not need to read data from the TextureSource, so no need to call GetTextureSource either.

The fix to this problem is simple, just depends on what info we want to dump.

Comment 2

[Benoit Girard (:BenWa)]

No, dumping the dataurl is slow and adds clutter. We just want to print the layer tree information. I wanted to check with you since you added the code.

Comment 3

[Nicolas Silva [:nical]]

Attachment: patch

with this patch, TextureHost prints the same info as DeprecatedTextureHost, and doesn't need to access a TextureSource

Comment 4

[Nicolas Silva [:nical]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/64c58cb9c49b

Comment 5

[Carsten Book [:Tomcat]]

sorry had to back this out because causing build bustages like https://tbpl.mozilla.org/php/getParsedLog.php?id=28140452&tree=Mozilla-Inbound

backout push is https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=7609a7ace997

Comment 6

[Nicolas Silva [:nical]]

Sorry about that. I am at a conference so if you guys need this fix quickly I'll let you fix the patch (it's really trivial), ortherwise I'll fix it on Monday.

Comment 7

[Nicolas Silva [:nical]]

fixed and relanded
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c771c423d44

As a side note this is an example of why I don't like to #ifdef out stuff like PrintInfo while still requiring it. Whenever we touch that code even in trivial ways it is very easy to break builds if we don't check both builds with and without MOZ_LAYERS_HAVE_LOG.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5c771c423d44