Closed
Bug 918182
Opened 11 years ago
Closed 10 years ago
Calendar Properties dialog has no value for refresh rate if is set to manual
Categories
(Calendar :: Dialogs, defect)
Calendar
Dialogs
Tracking
(Not tracked)
RESOLVED
FIXED
2.6.5
People
(Reporter: darktrojan, Assigned: darktrojan)
References
Details
Attachments
(1 file)
1.37 KB,
patch
|
bv1578
:
review+
Fallen
:
approval-calendar-aurora+
Fallen
:
approval-calendar-beta+
Fallen
:
approval-calendar-esr+
|
Details | Diff | Splinter Review |
A check mark is put on the 'Manually' item but it doesn't get selected. The check marks aren't used anywhere else in this popup.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #807040 -
Flags: review?(philipp) → review?(bv1578)
Comment on attachment 807040 [details] [diff] [review] 918182-1.diff Looks good. r=Decathlon This is safe enough for Aurora, Beta and esr24. Request approval as pro forma.
Attachment #807040 -
Flags: review?(bv1578)
Attachment #807040 -
Flags: review+
Attachment #807040 -
Flags: approval-calendar-release?(philipp)
Attachment #807040 -
Flags: approval-calendar-beta?(philipp)
Attachment #807040 -
Flags: approval-calendar-aurora?(philipp)
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Pushed to comm-central: http://hg.mozilla.org/comm-central/rev/237c7a7e3f20
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 3.1
Comment 4•10 years ago
|
||
Comment on attachment 807040 [details] [diff] [review] 918182-1.diff Fine with me :)
Attachment #807040 -
Flags: approval-calendar-release?(philipp)
Attachment #807040 -
Flags: approval-calendar-release+
Attachment #807040 -
Flags: approval-calendar-beta?(philipp)
Attachment #807040 -
Flags: approval-calendar-beta+
Attachment #807040 -
Flags: approval-calendar-aurora?(philipp)
Attachment #807040 -
Flags: approval-calendar-aurora+
Pushed to: comm-aurora -> http://hg.mozilla.org/releases/comm-aurora/rev/04d4cc61fd29 comm-beta -> http://hg.mozilla.org/releases/comm-beta/rev/8fac36362c59 comm-esr24 -> http://hg.mozilla.org/releases/comm-esr24/rev/3926543f24ff At the moment, what should it be the correct target milestone here?
Target Milestone: 3.1 → 2.9
Comment 6•10 years ago
|
||
(In reply to Decathlon from comment #5) > At the moment, what should it be the correct target milestone here? Theoretically, the version should be 2.6.5 if it landed on esr24. Although it does not exist as target milestone, and I do not know if Philipp wants to release an update for esr24. ;-)
Comment 7•10 years ago
|
||
Ok, I've created a 2.6.5 milestone, we can take this together with bug 927346. We have to wait until the next Thunderbird 24.x build is created though, and it would be great to do some QA testing for the release.
Target Milestone: 2.9 → 2.6.5
You need to log in
before you can comment on or make changes to this bug.
Description
•